Simplify tests by extracting boilerplate #27072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change just makes adding new tests easier
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- src/Controls/tests/DeviceTests/Resources/Raw/HybridTestRoot/invokedotnettests.html: Language not supported
Comments suppressed due to low confidence (1)
src/Controls/tests/DeviceTests/Elements/HybridWebView/HybridWebViewTests.cs:321
- [nitpick] The method name 'RunTest' is generic. Consider renaming it to something more descriptive like 'ExecuteHybridWebViewTest'.
Task RunTest(Func<HybridWebView, Task> test) =>
| @@ -523,5 +317,45 @@ await Retry(async () => | |||
| }, createExceptionWithTimeoutMS: (int timeoutInMS) => Task.FromResult(new Exception($"Waited {timeoutInMS}ms but couldn't get status element to have a non-empty value."))); | |||
| } | |||
| } | |||
|
|
|||
| Task RunTest(Func<HybridWebView, Task> test) => | |||
There was a problem hiding this comment.
Ensure that the refactored code, especially the new 'RunTest' method, is covered by tests in TestCases.Shared.Tests and can execute properly on TestCases.HostApp.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
jfversluis
approved these changes
Jan 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
I am planning on adding a bunch more tests and the duplicate code is making me sad. This PR does not change code and just refactors the tests a bit.