[Windows] - Fixed Window Title Not Shown When Reverting from TitleBar to Default State #27148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishnumenon2684
added
the
partner/syncfusion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Jan 16, 2025
|
Azure Pipelines successfully started running 3 pipeline(s). |
@jsuarezruiz, Thank you for the suggestion! The possibility of creating a UI test was explored, but during local testing, it was observed that the full window UI, including the TitleBar, is not captured, which prevents effective validation of this scenario through a UI test. Additionally, adding a UnitTest was considered; however, since the WindowTitle updates value as expected without the fix, Therefore, test cases were not included for this specific issue. Similarly TitleBar-related changes in PR #26568 excluded UI tests due to these same technical constraints. CI local Image :
|
Foda
approved these changes
Jan 29, 2025
|
Testing is for sure a PITA since we strip out the titlebar, so approving without test |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
When transitioning between the TitleBar and the Window Title, the window title fails to display correctly.
RootCause
During transitions between the TitleBar and the default Window Title, the ContentTemplate becomes null because the TitleBar sets Content directly without a template. This prevents the default template from being reapplied when reverting to the default Window Title, causing the title to not display.
Description of Change
When clearing the TitleBar (title bar is null), the method now checks if the ContentTemplate is null and reapplies the default template if necessary, ensuring the Window Title is restored properly during state changes.
Issues Fixed
Fixes #27022
Tested the behaviour in the following platforms
Output
Before-Fix.1.mp4
After-Fix.1.mp4
Test Case
Unable to add a test case for this scenario because the CI does not capture the window with the title bar. Additionally, creating a unit test is not feasible since the Window Title property updates correctly, but the changes are not reflected in the view.