-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Fix for NullReferenceException in WillMoveToParentViewController When Removing Page During Navigation #27275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @praveenkumarkarunanithi! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
jfversluis
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-navigation
NavigationPage
community ✨
Community Contribution
partner/syncfusion
Issues / PR's with Syncfusion collaboration
platform/iOS 🍎
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
The
NullReferenceException
occurs when a non-current page is removed from the navigation stack. Specifically, when RemovePage is invoked for a page that is not the current one, theNavigationPage.Legacy.RemovePage
method synchronously calls_removePageRequested?.Invoke(this, new NavigationRequestedEventArgs(page, true))
. This invocation triggers theRemovePage
method in the NavigationRenderer, which immediately callsDispose()
. TheDispose()
method then callsDisconnect()
, setting the Tracker to null before the nativeWillMoveToParentViewController
method is executed. As a result, whenWillMoveToParentViewController
attempts to access the now null Tracker, a NullReferenceException is thrown.In contrast, removing the current page using
PopAsync
handles the removal asynchronously. This ensures thatWillMoveToParentViewController
is called while the Tracker remains valid. Only after the native operations complete does Disconnect(false) nullify the Tracker. This proper sequencing maintains the integrity of the Tracker during native method execution, preventing the exception when usingPopAsync
.Description of Change
The fix adds a null check for
ToolbarTracker
in theWillMoveToParentViewController
method, ensuring it is accessed only when initialized, thereby preventing theNullReferenceException
.Issues Fixed
Fixes #25726
Tested the behaviour in the following platforms
Screenshots
BeforeFix.mov
AfterFix.mov