-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fixed Label Visibility Issue on macOS and iOS #28081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ad87f31
Fixed Label Display on macOS and IOS When Padding is Applied
Dhivya-SF4094 d5f822f
Optimized the fix
Dhivya-SF4094 e768384
Added test case
Dhivya-SF4094 e9fae04
Added Snapshot for android and iOS
Dhivya-SF4094 0ad0e70
Added snapshot for winUI and macOS, updated test sample
Dhivya-SF4094 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+24.2 KB
src/Controls/tests/TestCases.Android.Tests/snapshots/android/LabelWithPadding.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| namespace Maui.Controls.Sample.Issues | ||
| { | ||
| [Issue(IssueTracker.Github, 19007, "Incomplete Label Display on macOS and IOS When Padding is Applied", PlatformAffected.iOS)] | ||
| public class Issue19007 : ContentPage | ||
| { | ||
| public Issue19007() | ||
| { | ||
| var grid = new Grid(); | ||
| grid.RowDefinitions.Add(new RowDefinition { Height = GridLength.Auto }); | ||
| grid.ColumnDefinitions.Add(new ColumnDefinition { Width = new GridLength(100) }); | ||
|
|
||
| var label = new Label | ||
| { | ||
| Background = Colors.Red, | ||
| Text = ".NET Multi-platform App UI (.NET MAUI) is a cross-platform framework for creating mobile and desktop apps with C# and XAML.", | ||
| Padding = new Thickness(20), | ||
| AutomationId = "Label" | ||
| }; | ||
|
|
||
| grid.Children.Add(label); | ||
| Grid.SetRow(label, 0); | ||
| Grid.SetColumn(label, 0); | ||
|
|
||
| Content = grid; | ||
| } | ||
| } | ||
| } |
Binary file added
BIN
+16.2 KB
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/LabelWithPadding.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions
21
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19007.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
| public class Issue19007 : _IssuesUITest | ||
| { | ||
| public Issue19007(TestDevice testDevice) : base(testDevice) | ||
| { | ||
| } | ||
|
|
||
| public override string Issue => "Incomplete Label Display on macOS and IOS When Padding is Applied"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.Label)] | ||
| public void LabelWithPadding() | ||
| { | ||
| App.WaitForElement("Label"); | ||
| VerifyScreenshot(); | ||
| } | ||
| } |
Binary file added
BIN
+6.24 KB
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/LabelWithPadding.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+43.2 KB
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/LabelWithPadding.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.