[Testing] Migration of Compatibility.Core platform-specific unit tests into device tests - 5 #28193

TamilarasanSF4853 · 2025-03-05T17:16:04Z

Description of Change

Migration of Compatibility.Core platform-specific unit tests to device tests. Here the migrated cases which ensuring that the IsEnabled and CornerRadius consistency of different elements matches their native counterparts. We are going to migrate tests in blocks in different PRs. This is the 5st group.

There are unit tests under:

src\Compatibility\Core\tests\Android
src\Compatibility\Core\tests\iOS
src\Compatibility\Core\tests\WinUI

That are not running right now. these cases from Xamarin.Forms where they could run as unit tests, but now with .NET MAUI this is not possible. So here I migrated the following cases in device tests.

This pull request includes several changes to the Android device tests for various UI elements. The primary focus is on adding tests to ensure that the properties ScaleX, ScaleY, Scale, RotationX, RotationY, and Rotation of different UI elements are consistent with their native counterparts.

New tests for property consistency:

src/Controls/tests/DeviceTests/Elements/BoxView/BoxViewTests.Android.cs: Added tests to verify that the ScaleX, ScaleY, Scale, RotationX, RotationY, and Rotation properties of a BoxView are consistent with the native properties.
src/Controls/tests/DeviceTests/Elements/Button/ButtonTests.Android.cs: Added tests to verify that the ScaleX, ScaleY, Scale, RotationX, RotationY, and Rotation properties of a Button are consistent with the native properties. [1] [2]
src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.Android.cs: Added tests to verify that the ScaleX, ScaleY, Scale, RotationX, RotationY, and Rotation properties of a CheckBox are consistent with the native properties. [1] [2]
src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.Android.cs: Added tests to verify that the ScaleX, ScaleY, Scale, RotationX, RotationY, and Rotation properties of an Editor are consistent with the native properties. [1] [2]
src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.Android.cs: Added tests to verify that the ScaleX, ScaleY, Scale, RotationX, RotationY, and Rotation properties of an Entry are consistent with the native properties. [1] [2]
src/Controls/tests/DeviceTests/Elements/Image/ImageTests.Android.cs: Added tests to verify that the ScaleX, ScaleY, Scale, RotationX, RotationY, and Rotation properties of an Image are consistent with the native properties. [1] [2]

Minor changes:

Added System.ComponentModel and other necessary namespaces to several test files to support the new tests. [1] [2] [3] [4] [5] [6]

Issues Fixed

Fixes #27303

dotnet-policy-service · 2025-03-05T17:16:25Z

Hey there @TamilarasanSF4853! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot

PR Overview

This PR migrates several Compatibility.Core platform-specific unit tests into device tests for Android (with some minor updates in iOS and shared test files), ensuring that UI elements’ Scale and Rotation properties match their native counterparts. Key changes include:

Adding device tests for ScaleX, ScaleY, Scale, RotationX, RotationY, and Rotation for elements like Image, Entry, Picker, Label, TabbedPage, SwipeView, SearchBar, Button, Editor, CheckBox, TemplatedView, and BoxView.
Introducing necessary namespace imports (e.g. System.ComponentModel) to support the new tests.
Minor adjustments in existing files (e.g. Label tests) to align with the migrated test structure.

Reviewed Changes

File	Description
src/Controls/tests/DeviceTests/Elements/Image/ImageTests.Android.cs	New tests for verifying Scale and Rotation properties on Image.
src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.Android.cs	New tests for verifying Scale and Rotation properties on Entry.
src/Controls/tests/DeviceTests/Elements/Picker/PickerTests.Android.cs	New tests for verifying Scale and Rotation properties on Picker.
src/Controls/tests/DeviceTests/Elements/Label/LabelTests.Android.cs	New tests for verifying Scale and Rotation properties on Label.
src/Controls/tests/DeviceTests/Elements/TabbedPage/TabbedPageTests.Android.cs	New tests for verifying Scale and Rotation properties on TabbedPage.
src/Controls/tests/DeviceTests/Elements/SwipeView/SwipeViewTests.Android.cs	New tests for verifying Scale and Rotation properties on SwipeView.
src/Controls/tests/DeviceTests/Elements/SearchBar/SearchBarTests.Android.cs	New tests for verifying Scale and Rotation properties on SearchBar.
src/Controls/tests/DeviceTests/Elements/Button/ButtonTests.Android.cs	New tests for verifying Scale and Rotation properties on Button.
src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.Android.cs	New tests for verifying Scale and Rotation properties on Editor.
src/Controls/tests/DeviceTests/Elements/CheckBox/CheckBoxTests.Android.cs	New tests for verifying Scale and Rotation properties on CheckBox.
src/Controls/tests/DeviceTests/Elements/TemplatedView/TemplatedViewTests.Android.cs	New tests for verifying Scale and Rotation properties on TemplatedView.
src/Controls/tests/DeviceTests/Elements/BoxView/BoxViewTests.Android.cs	New tests for verifying Scale and Rotation properties on BoxView.
src/Controls/tests/DeviceTests/Elements/Label/LabelTests.iOS.cs	New RTL tests for Label with FormattedText and LineHeight.
src/Controls/tests/DeviceTests/Elements/Label/LabelTests.cs	Minor comment adjustment for Label background color consistency.

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.Android.cs:69

[nitpick] Consider renaming 'PlatformEditor' to 'platformEditor' for consistency with local variable naming conventions.

var PlatformEditor = GetPlatformControl(handler);

src/Controls/tests/DeviceTests/Elements/TemplatedView/TemplatedViewTests.Android.cs

jsuarezruiz · 2025-03-06T06:58:26Z

/azp run

azure-pipelines · 2025-03-06T06:58:45Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz

Could you rebase to fix the conflicts?

TamilarasanSF4853 · 2025-03-07T10:12:07Z

Could you rebase to fix the conflicts?

@jsuarezruiz I’ve rebased and resolved the conflicts

jsuarezruiz · 2025-03-07T11:32:08Z

/azp run

azure-pipelines · 2025-03-07T11:32:29Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-03-10T07:26:20Z

/rebase

jsuarezruiz · 2025-03-10T07:30:48Z

/azp run

azure-pipelines · 2025-03-10T07:31:08Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-03-14T10:29:56Z

/rebase

…dViewTests.Android.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

This reverts commit 1f5c535.

jsuarezruiz · 2025-03-14T10:31:19Z

/azp run

azure-pipelines · 2025-03-14T10:31:39Z

Azure Pipelines successfully started running 3 pipeline(s).

…s into device tests - 5 (#28193) * Test case added * Update LabelTests.iOS.cs * test case added * code changes * reverted changes * Update src/Controls/tests/DeviceTests/Elements/TemplatedView/TemplatedViewTests.Android.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * handler code change * conflict code changes * flow direction test * Revert "flow direction test" This reverts commit 1f5c535. * Reverted changes --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com>

dotnet-policy-service bot added the community ✨ Community Contribution label Mar 5, 2025

dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Mar 5, 2025

ghost added the area-testing Unit tests, device tests label Mar 6, 2025

TamilarasanSF4853 marked this pull request as ready for review March 6, 2025 05:06

Copilot AI review requested due to automatic review settings March 6, 2025 05:06

TamilarasanSF4853 requested a review from a team as a code owner March 6, 2025 05:06

TamilarasanSF4853 requested review from StephaneDelcroix and jfversluis March 6, 2025 05:06

Copilot AI reviewed Mar 6, 2025

View reviewed changes

src/Controls/tests/DeviceTests/Elements/TemplatedView/TemplatedViewTests.Android.cs Outdated Show resolved Hide resolved

jsuarezruiz reviewed Mar 7, 2025

View reviewed changes

TamilarasanSF4853 force-pushed the Enabled-UnitTest-To-DeviceTest-3 branch from e57e5a7 to 66c4e51 Compare March 7, 2025 09:22

github-actions bot force-pushed the Enabled-UnitTest-To-DeviceTest-3 branch from 71e9c48 to b1b3969 Compare March 10, 2025 07:26

dotnet deleted a comment from azure-pipelines bot Mar 14, 2025

TamilarasanSF4853 and others added 7 commits March 14, 2025 10:30

Test case added

b0cfdbe

Update LabelTests.iOS.cs

1e1836f

test case added

9f38a7d

code changes

d05e16c

reverted changes

c7451d1

Update src/Controls/tests/DeviceTests/Elements/TemplatedView/Template…

bc4fe3e

…dViewTests.Android.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

handler code change

6af8348

TamilarasanSF4853 and others added 4 commits March 14, 2025 10:30

conflict code changes

b22b578

flow direction test

c14cffd

Revert "flow direction test"

84595f4

This reverts commit 1f5c535.

Reverted changes

6deb60b

github-actions bot force-pushed the Enabled-UnitTest-To-DeviceTest-3 branch from 23bb64f to 6deb60b Compare March 14, 2025 10:30

jsuarezruiz approved these changes Mar 18, 2025

View reviewed changes

PureWeen changed the base branch from main to inflight/current March 18, 2025 18:21

PureWeen merged commit cd3b13b into dotnet:inflight/current Mar 18, 2025
128 checks passed

github-actions bot locked and limited conversation to collaborators Apr 18, 2025

[Testing] Migration of Compatibility.Core platform-specific unit tests into device tests - 5 #28193

[Testing] Migration of Compatibility.Core platform-specific unit tests into device tests - 5 #28193

Uh oh!

Conversation

TamilarasanSF4853 commented Mar 5, 2025

Description of Change

Issues Fixed

Uh oh!

dotnet-policy-service bot commented Mar 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

PR Overview

Reviewed Changes

Uh oh!

Uh oh!

jsuarezruiz commented Mar 6, 2025

Uh oh!

azure-pipelines bot commented Mar 6, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

TamilarasanSF4853 commented Mar 7, 2025

Uh oh!

jsuarezruiz commented Mar 7, 2025

Uh oh!

azure-pipelines bot commented Mar 7, 2025

Uh oh!

jsuarezruiz commented Mar 10, 2025

Uh oh!

jsuarezruiz commented Mar 10, 2025

Uh oh!

azure-pipelines bot commented Mar 10, 2025

Uh oh!

jsuarezruiz commented Mar 14, 2025

Uh oh!

jsuarezruiz commented Mar 14, 2025

Uh oh!

azure-pipelines bot commented Mar 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants