Skip to content

Fix for border color of the RadioButton is visible in Windows #28214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 25, 2025
Merged

Fix for border color of the RadioButton is visible in Windows #28214

merged 7 commits into from
Mar 25, 2025

Conversation

@SyedAbdulAzeemSF4852
Copy link
Contributor

@SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 commented Mar 6, 2025 •
edited
Loading

Issue Details

  • The border color of the radiobutton is visible only in windows.

Root Cause

  • If the stroke thickness is not explicitly set, a default Thickness object with a value of 3 is created, causing the border to be visible.

Description of Change

  • If the stroke thickness is not explicitly set, then created a default thickness object with a value of 0.

Validated the behaviour in the following platforms

  • Windows

  • Android

  • iOS

  • Mac

Issues Fixed

Fixes #28153

Output

Before Fix After Fix

Other Platforms Output

Android iOS Mac

@dotnet-policy-service dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Mar 6, 2025
@SyedAbdulAzeemSF4852
Copy link
Contributor Author

SyedAbdulAzeemSF4852 commented Mar 6, 2025

@dotnet-policy-service agree company="Syncfusion, Inc."

@jsuarezruiz jsuarezruiz added the area-controls-radiobutton RadioButton, RadioButtonGroup label Mar 6, 2025
@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Mar 6, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 6, 2025

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz reviewed Mar 6, 2025
View reviewed changes
src/Controls/tests/TestCases.HostApp/Issues/Issue28153.cs Outdated
{
AutomationId = "RadioButton",
Content = "RadioButton",
BorderColor = Colors.Red
Copy link
Contributor

@jsuarezruiz jsuarezruiz Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could include two radioButtons, one of them using the StrokeThickness property to validate all the scenarios with a single snapshot.

Copy link
Contributor Author

@SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz , I have modified the test case. Please let me know if you have any concerns.

jsuarezruiz
jsuarezruiz suggested changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows, with the changes needs to review and update some failing tests:
image

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Mar 11, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 11, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 marked this pull request as ready for review March 11, 2025 11:00
@SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 requested a review from a team as a code owner March 11, 2025 11:00
jsuarezruiz
jsuarezruiz suggested changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two tests keeps failing on Windows:
image

Small differences on both cases in the snapshots. Could you take a look?

@SyedAbdulAzeemSF4852
Copy link
Contributor Author

SyedAbdulAzeemSF4852 commented Mar 14, 2025

These two tests keeps failing on Windows: image

Small differences on both cases in the snapshots. Could you take a look?

@jsuarezruiz , I've reviewed the snapshots and have committed the latest snapshots.

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Mar 17, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 17, 2025

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz suggested changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test ValidateRadioButtonNoBorderColorWhenNoBorderWidth is failing on Android, iOS, Mac.

On iOS:
Snapshot different than baseline: ValidateRadioButtonNoBorderColorWhenNoBorderWidth.png (3.44% difference)

This is the result:
image

@SyedAbdulAzeemSF4852
Copy link
Contributor Author

SyedAbdulAzeemSF4852 commented Mar 18, 2025

@jsuarezruiz , I have committed the latest snapshots.

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Mar 21, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 21, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho merged commit 43fd3fa into dotnet:main Mar 25, 2025
128 checks passed
@rmarinho rmarinho added this to the .NET 9 SR6 milestone Mar 25, 2025
@SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 mentioned this pull request Mar 27, 2025
Open
4 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis was automatically assigned from dotnet/dotnet-maui-reviewers

1 more reviewer

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-controls-radiobutton RadioButton, RadioButtonGroup community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Milestone

.NET 9 SR6

Development

Successfully merging this pull request may close these issues.

The border color of the RadioButton is visible in Windows only

3 participants

@SyedAbdulAzeemSF4852 @jsuarezruiz @rmarinho