Skip to content

Conversation

@Redth
Copy link
Member

@Redth Redth commented Mar 6, 2025

We only want the major version in brew install --cask microsoft-openjdk@17 instead of the full version which would incorrectly attempt brew install --cask microsoft-openjdk@17.0.12.

We only want the major version in `brew install --cask microsoft-openjdk@17` instead of the full version which would incorrectly attempt `brew install --cask microsoft-openjdk@17.0.12`.
Copilot AI review requested due to automatic review settings March 6, 2025 14:53
@Redth Redth requested a review from a team as a code owner March 6, 2025 14:53
@Redth Redth requested review from mattleibow and rmarinho March 6, 2025 14:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@rmarinho rmarinho moved this from Todo to Ready To Review in MAUI SDK Ongoing Mar 6, 2025
@rmarinho rmarinho added this to the .NET 10.0-preview2 milestone Mar 6, 2025
@rmarinho rmarinho merged commit f024b72 into main Mar 7, 2025
125 of 128 checks passed
@rmarinho rmarinho deleted the dev/redth/provision-jdk-macos-fix branch March 7, 2025 01:12
@github-project-automation github-project-automation bot moved this from Ready To Review to Done in MAUI SDK Ongoing Mar 7, 2025
bhavanesh2001 pushed a commit to bhavanesh2001/maui that referenced this pull request Mar 7, 2025
We only want the major version in `brew install --cask microsoft-openjdk@17` instead of the full version which would incorrectly attempt `brew install --cask microsoft-openjdk@17.0.12`.
rmarinho pushed a commit that referenced this pull request Mar 11, 2025
We only want the major version in `brew install --cask microsoft-openjdk@17` instead of the full version which would incorrectly attempt `brew install --cask microsoft-openjdk@17.0.12`.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants