-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS ]Fix for issue -> Disconnecting Map Handler causes Map to crash on second page entrance and moving to region #28795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There are some build errors here
Also this introduces new public APIs. If we want to fix this for .NET 9 we will need to find a way to do it without that, else it will probably be a fix for .NET 10. What we probably can do is make the public members internal for now? Can you please address these @AnthonyNjuguna ? |
|
This also fixes the issue #29346 |
|
@PureWeen @jfversluis We’ve fixed the build errors and added a test for the fix in the PR below. Could you please close this PR in favor of the new one? |
|
@AnthonyNjuguna Could you rebase and fix the conflict? Thanks in advance. |
|
Closed favor of this PR #29369 |
Description of Change
Added the ability to set the handler outside of the constructor so when it is re-used from the pool the handler will not be null and cause crashes like #20612
Issues Fixed
Fixes #20612