Revert "Fix HideSoftInputOnTapped Not Working Net9 " #28802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey there @@SuthiYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
community ✨
SuthiYuvaraj
requested review from
PureWeen and
mattleibow
and removed request for
a team
Member
|
/rebase |
This reverts commit f3ec03b.
PureWeen
force-pushed
the
revert-28534-fix-26792-preview
branch
from
9b13427 to
77b05e0
Compare
PureWeen
approved these changes
Apr 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #28534
Description for revert:
This PR has been reverted due to differing behavior on iOS when dynamically changing the page associated with a Window. In the HostApp, the page is directly assigned to the
Window. When running a test case, the selected item from the test case is assigned toApplication.Current.Windows[0].Page.During this page swap, the Page Mapper is triggered before the old page is removed and the new page is added. As a result, the
PropertyMapperexecutes early, and theHideSoftInputOnTappedproperty is updated. This property relies on thePage.Parent, which isnullat that point, causing a failure on iOS.Meanwhile, Android updates the page properties only after the previous page has been removed and the new page has been added to the window, which avoids this issue