Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
src/Controls/tests/TestCases.HostApp/TestCases.cs:294
- Consider adding a type-check or null-check for grid.BindingContext before casting to IssueModel to prevent potential runtime errors if the BindingContext is not as expected.
var issueModel = (IssueModel)grid.BindingContext;
src/Controls/tests/TestCases.HostApp/TestCases.cs:279
- Ensure that the new CollectionView item template is adequately covered by automated tests in both TestCases.HostApp and TestCases.Shared.Tests to validate its behavior and layout.
ItemTemplate = new DataTemplate(() => {
Contributor
Author
|
Related with #28327 |
PureWeen
requested changes
Apr 8, 2025
Member
PureWeen
left a comment
There was a problem hiding this comment.
I think we should still target main with this one (or the testflight branch)
If net10 and net9 runners start falling out of sync that's going to probably be hard to maintain down the road
Member
|
yeah I agree, we want to have this on main so it s in sync when we merge main to net10 |
Contributor
Author
|
Retarget to |
rmarinho
approved these changes
May 19, 2025
jfversluis
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Update Test HostApp to not use TableView and use CollectionView instead.
Issues Fixed
Related with #28698