[release/9.0.1xx-sr5] Backport uitest fixes to .NET9 SR5 #28871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Resolved the ScrollView TestFailures in Inflight. * updated ReorderBetweenGroupsShouldNotOccurWhenCanMixGroupsIsFalse ios image * Updated EntryClearButtonColorShouldMatchTextColor mac image # Conflicts: # src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/ReorderBetweenGroupsShouldNotOccurWhenCanMixGroupsIsFalse.png # src/Core/src/Handlers/ScrollView/ScrollViewHandler.iOS.cs
# Conflicts: # src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/DynamicFontImageSourceColorShouldApplyOnTabIcon.png # src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/FontImageSourceColorShouldApplyOnTabIcon.png # src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/TabbedPageBackButtonUpdated.png
* set scrollbar visibility to false * change snapshot * set scroll bar visiblity only for android
PureWeen
requested review from
rmarinho and
tj-devel709
and removed request for
a team
Contributor
There was a problem hiding this comment.
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/Controls/tests/TestCases.HostApp/Issues/Issue28098.xaml: Language not supported
Comments suppressed due to low confidence (1)
src/Controls/tests/TestCases.HostApp/Issues/Issue28098.xaml.cs:12
- Consider adding or verifying an automated test case to ensure this Android-specific behavior change is validated in TestCases.Shared.Tests.
carouselView.HorizontalScrollBarVisibility = ScrollBarVisibility.Never;
Member
Author
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Member
|
I think we need maybe some images for FooterWithEmptyCVShouldHaveCorrectSize ? |
Member
Author
This test is a legitimate failure on the SR5 branch that we need to figure out and it's unlreated to this PR |
github-project-automation
bot
moved this from Ready To Review
to Done
in MAUI SDK Ongoing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Pulling together a few fixes for flakey tests on main so it's easier to trust the CI results from SR5 runs