[Windows] Fixed BarTextColor applied to secondary toolbar items #28932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
community ✨
MartyIX
reviewed
Apr 11, 2025
| @@ -0,0 +1,61 @@ | |||
| namespace Maui.Controls.Sample.Issues | |||
There was a problem hiding this comment.
This can be file-scoped namespace, if you need to touch the PR again.
There was a problem hiding this comment.
@MartyIX Modified
|
/azp run MAUI-UITests-public |
jsuarezruiz
reviewed
Apr 14, 2025
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
approved these changes
Apr 15, 2025
PureWeen
pushed a commit
that referenced
this pull request
Apr 23, 2025
* Fixed bar textcolor used in secondary toolbar * Update MauiToolbar.xaml.cs * resolved the changes * Update Issue20177.cs * modified issue string * added windows snapshot
prakashKannanSf3972
pushed a commit
to prakashKannanSf3972/maui
that referenced
this pull request
Apr 24, 2025
…et#28932) * Fixed bar textcolor used in secondary toolbar * Update MauiToolbar.xaml.cs * resolved the changes * Update Issue20177.cs * modified issue string * added windows snapshot
NanthiniMahalingam
pushed a commit
to NanthiniMahalingam/maui
that referenced
this pull request
Apr 24, 2025
…et#28932) * Fixed bar textcolor used in secondary toolbar * Update MauiToolbar.xaml.cs * resolved the changes * Update Issue20177.cs * modified issue string * added windows snapshot
prakashKannanSf3972
pushed a commit
to prakashKannanSf3972/maui
that referenced
this pull request
Apr 25, 2025
…et#28932) * Fixed bar textcolor used in secondary toolbar * Update MauiToolbar.xaml.cs * resolved the changes * Update Issue20177.cs * modified issue string * added windows snapshot
prakashKannanSf3972
pushed a commit
to prakashKannanSf3972/maui
that referenced
this pull request
Apr 28, 2025
…et#28932) * Fixed bar textcolor used in secondary toolbar * Update MauiToolbar.xaml.cs * resolved the changes * Update Issue20177.cs * modified issue string * added windows snapshot
github-actions bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
* Fixed bar textcolor used in secondary toolbar * Update MauiToolbar.xaml.cs * resolved the changes * Update Issue20177.cs * modified issue string * added windows snapshot
PureWeen
pushed a commit
that referenced
this pull request
May 2, 2025
* Fixed bar textcolor used in secondary toolbar * Update MauiToolbar.xaml.cs * resolved the changes * Update Issue20177.cs * modified issue string * added windows snapshot
SuthiYuvaraj
pushed a commit
to SuthiYuvaraj/maui
that referenced
this pull request
May 9, 2025
…et#28932) * Fixed bar textcolor used in secondary toolbar * Update MauiToolbar.xaml.cs * resolved the changes * Update Issue20177.cs * modified issue string * added windows snapshot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with the toolbar item text color in the Windows platform and includes the addition of a new test case to ensure the issue is resolved.
Root cause
The
BarTextColoris applied to all toolbar items. However, the background is only set for the command bar. The background of the secondary toolbar items container is not customizable and remains white. Consequently, when the text color is white, the secondary toolbar items become invisible.Description of Change
Toolbar text color update:
UpdateTextColormethod call forToolbarItemOrder.Primaryitems to ensure the correct text color is applied only to primary toolbar items (src/Controls/src/Core/Toolbar/Toolbar.Windows.cs).New test case for issue 20177:
BarTextColor(src/Controls/tests/TestCases.HostApp/Issues/Issue20177.cs).src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20177.cs).Issues Fixed
Fixes #20177
Validated the behaviour in the following platforms
Output
Before.2.mp4
After.1.mp4