-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fixed - On iOS GestureRecognizers don't work on Span in a Label, which doesn't get IsVisible (=true) update from its parent #29024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PureWeen
merged 4 commits into
dotnet:inflight/current
from
KarthikRajaKalaimani:fix-28949
Apr 28, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 28949, "On iOS GestureRecognizers don't work on Span in a Label, which doesn't get IsVisible (=true) update from its parent", PlatformAffected.iOS)] | ||
| public class Issue28949 : ContentPage | ||
| { | ||
| public Issue28949() | ||
| { | ||
| var toggleButton = new Button | ||
| { | ||
| Text = "Toggle Visibility", | ||
| AutomationId = "ToggleButton" | ||
| }; | ||
| var formattedString = new FormattedString(); | ||
| var label = new Label | ||
| { | ||
| FormattedText = formattedString, | ||
| BackgroundColor = Colors.Transparent, | ||
| AutomationId = "Label" | ||
| }; | ||
| var grid = new Grid | ||
| { | ||
| BackgroundColor = Colors.Yellow | ||
| }; | ||
|
|
||
| var span = new Span | ||
| { | ||
| Text = "Click me", | ||
| TextColor = Colors.Pink | ||
| }; | ||
| var tapGesture = new TapGestureRecognizer(); | ||
| tapGesture.Tapped += (s, e) => | ||
| { | ||
| span.Text = "Success"; | ||
| span.TextColor = Colors.Green; | ||
| }; | ||
| span.GestureRecognizers.Add(tapGesture); | ||
| formattedString.Spans.Add(span); | ||
|
|
||
| toggleButton.Clicked += (s, e) => | ||
| { | ||
| grid.IsVisible = !grid.IsVisible; | ||
| }; | ||
| grid.IsVisible = false; | ||
| grid.Children.Add(label); | ||
| var stackLayout = new StackLayout | ||
| { | ||
| Children = | ||
| { | ||
| toggleButton, | ||
| grid | ||
| } | ||
| }; | ||
| Content = stackLayout; | ||
| } | ||
|
|
||
| } |
25 changes: 25 additions & 0 deletions
25
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28949.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
|
||
| public class Issue28949 : _IssuesUITest | ||
| { | ||
| public Issue28949(TestDevice device) : base(device) | ||
| { | ||
| } | ||
|
|
||
| public override string Issue => "On iOS GestureRecognizers don't work on Span in a Label, which doesn't get IsVisible (=true) update from its parent"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.Label)] | ||
| public void GestureRecognizersOnLabelSpanShouldWork() | ||
| { | ||
| App.WaitForElement("ToggleButton"); | ||
| App.Tap("ToggleButton"); | ||
| var spanRect = App.WaitForElement("Label").GetRect(); | ||
| App.TapCoordinates(spanRect.X + 5, spanRect.Y + 5); | ||
| App.WaitForElement("Success"); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider updating the XML documentation for RecalculateSpanPositions to document the new 'size' parameter and its role in reflecting the arranged bounds from LabelHandler. This will help maintain clarity for future developers maintaining this internal method.