Skip to content

Conversation

@LogishaSelvarajSF4525
Copy link
Contributor

This PR includes a comprehensive set of UI test cases for the CollectionView control. The tests validate the ItemsSource feature functionality in CollectionView, including properties such as: Add Items, Remove Items, PreSelection, CurrentSelection, ItemsSource.

New Features and Pages:

  • CollectionViewItemsSourcePage: Added a new page to demonstrate and manage ItemsSource features for CollectionView. This includes functionalities like adding/removing items, updating selection modes, and displaying current/previous selections.
  • ItemsSourceOptionsPage: Added a new page to configure ItemsSource options such as type, grouping, and selection mode. This page allows dynamic changes to the ItemsSource settings via radio buttons and applies them to the CollectionView.
  • Implemented logic in CollectionViewItemsSourcePage.xaml.cs to handle item addition/removal, selection updates, and pre-selection based on conditions. This includes error handling and UI updates for user interactions.
  • Added logic in ItemsSourceOptionsPage.xaml.cs to dynamically update ItemsSource configurations based on user input from the options page.

These changes significantly enhance the flexibility and functionality of CollectionView by allowing developers to dynamically manage and configure ItemsSource behaviors.

@LogishaSelvarajSF4525 LogishaSelvarajSF4525 added area-testing Unit tests, device tests partner/syncfusion Issues / PR's with Syncfusion collaboration labels May 5, 2025
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label May 5, 2025
@LogishaSelvarajSF4525 LogishaSelvarajSF4525 marked this pull request as ready for review May 6, 2025 04:46
Copilot AI review requested due to automatic review settings May 6, 2025 04:46
@LogishaSelvarajSF4525 LogishaSelvarajSF4525 requested a review from a team as a code owner May 6, 2025 04:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive UI test cases and new pages to verify and configure the CollectionView ItemsSource feature. The key changes include renaming and aligning test class names, adding new UI pages for ItemsSource options and actions, and implementing test logic for item management in CollectionView.

Reviewed Changes

Copilot reviewed 20 out of 23 changed files in this pull request and generated 1 comment.

File Description
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/CollectionView_GroupingFeatureTests.cs Renaming test class for clarity and consistency with the file name.
src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/ItemsSource/ItemsSourceOptionsPage.xaml.cs New page for configuring ItemsSource options with radio button inputs.
src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/ItemsSource/CollectionViewItemsSourcePage.xaml.cs New page implementing item addition/removal and selection handling for CollectionView.
src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewFeaturePage.xaml.cs Updated navigation to include the new ItemsSource page.
Files not reviewed (3)
  • src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewFeaturePage.xaml: Language not supported
  • src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/ItemsSource/CollectionViewItemsSourcePage.xaml: Language not supported
  • src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/ItemsSource/ItemsSourceOptionsPage.xaml: Language not supported

@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some build errors:

C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\FeatureMatrix\CollectionView\ItemsSource\CollectionViewItemsSourcePage.xaml.cs(95,53): error CS0117: 'ItemsSourceType' does not contain a definition for 'ObservableCollectionStringT' [C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.20348.0]
C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\FeatureMatrix\CollectionView\ItemsSource\CollectionViewItemsSourcePage.xaml.cs(95,53): error CS0117: 'ItemsSourceType' does not contain a definition for 'ObservableCollectionStringT' [C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.19041.0]
    22 Warning(s)
    2 Error(s)

Could you fix it?

@LogishaSelvarajSF4525
Copy link
Contributor Author

There are some build errors:

C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\FeatureMatrix\CollectionView\ItemsSource\CollectionViewItemsSourcePage.xaml.cs(95,53): error CS0117: 'ItemsSourceType' does not contain a definition for 'ObservableCollectionStringT' [C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.20348.0]
C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\FeatureMatrix\CollectionView\ItemsSource\CollectionViewItemsSourcePage.xaml.cs(95,53): error CS0117: 'ItemsSourceType' does not contain a definition for 'ObservableCollectionStringT' [C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.19041.0]
    22 Warning(s)
    2 Error(s)

Could you fix it?

@jsuarezruiz I have resolved the build errors and committed the changes.

@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsuarezruiz
Copy link
Contributor

@LogishaSelvarajSF4525 Could you rebase and fix the conflicts?

@LogishaSelvarajSF4525
Copy link
Contributor Author

LogishaSelvarajSF4525 commented May 22, 2025

@LogishaSelvarajSF4525 Could you rebase and fix the conflicts?

@jsuarezruiz I have resolved conflicts.

@ghost ghost force-pushed the logi-itemssourcefeature branch from 9ce3673 to e7a906f Compare May 31, 2025 04:44
@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PureWeen PureWeen changed the base branch from main to inflight/current June 6, 2025 15:32
@PureWeen PureWeen merged commit da91f33 into dotnet:inflight/current Jun 6, 2025
78 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 7, 2025
…Feature (#29322)

* added ItemsSource feature Tests

* modified changes

* updated changes

* Update src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/ItemsSource/CollectionViewItemsSourcePage.xaml.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* modified changes

* added snapshots

* modified changes

* modified changes

* modified changes

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jun 10, 2025
…Feature (#29322)

* added ItemsSource feature Tests

* modified changes

* updated changes

* Update src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/ItemsSource/CollectionViewItemsSourcePage.xaml.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* modified changes

* added snapshots

* modified changes

* modified changes

* modified changes

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jun 10, 2025
…Feature (#29322)

* added ItemsSource feature Tests

* modified changes

* updated changes

* Update src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/ItemsSource/CollectionViewItemsSourcePage.xaml.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* modified changes

* added snapshots

* modified changes

* modified changes

* modified changes

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jun 11, 2025
…Feature (#29322)

* added ItemsSource feature Tests

* modified changes

* updated changes

* Update src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/ItemsSource/CollectionViewItemsSourcePage.xaml.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* modified changes

* added snapshots

* modified changes

* modified changes

* modified changes

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jun 11, 2025
…Feature (#29322)

* added ItemsSource feature Tests

* modified changes

* updated changes

* Update src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/ItemsSource/CollectionViewItemsSourcePage.xaml.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* modified changes

* added snapshots

* modified changes

* modified changes

* modified changes

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jun 16, 2025
…Feature (#29322)

* added ItemsSource feature Tests

* modified changes

* updated changes

* Update src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/ItemsSource/CollectionViewItemsSourcePage.xaml.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* modified changes

* added snapshots

* modified changes

* modified changes

* modified changes

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jun 16, 2025
…Feature (#29322)

* added ItemsSource feature Tests

* modified changes

* updated changes

* Update src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/ItemsSource/CollectionViewItemsSourcePage.xaml.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* modified changes

* added snapshots

* modified changes

* modified changes

* modified changes

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jun 19, 2025
…Feature (#29322)

* added ItemsSource feature Tests

* modified changes

* updated changes

* Update src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/ItemsSource/CollectionViewItemsSourcePage.xaml.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* modified changes

* added snapshots

* modified changes

* modified changes

* modified changes

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
PureWeen added a commit that referenced this pull request Jun 21, 2025
For more information about inflight process check
https://github.com/dotnet/maui/wiki/Inflight-Branch-Process

# .NET MAUI Release Notes - inflight/candidate Branch

## MAUI Product Fixes
* [iOS] Fix SwipeView programmatic open when background color is set by
@Shalini-Ashokan in #29765
* [iOS] FormattedText with text color causes stack overflow - fix by
@kubaflo in #29874
* [iOS] Fix AdaptiveTrigger not working as expected by @jsuarezruiz in
#20987
* [iOS] Fix for Flyout title is not broken over multiple lines when you
rotate your screen by @BagavathiPerumal in
#29171
* [Windows] Fix for Assigning null to the SelectedItem of the
CollectionView in the SelectionChanged event does not clear the
selection by @SyedAbdulAzeemSF4852 in
#29288
* Fix TapCoordinates method in Catalyst by @jsuarezruiz in
#29775
* Fixed ItemSpacing on CarouselView resizes items [Android] by
@Dhivya-SF4094 in #29796
* Perf : ButtonContentTypeConverter now using InvariantCulture to parse
double by @antoine-jonathan in #25393
* ToolbarItem behavior with ImageSource iOS - fix by @kubaflo in
#28833
* [Android] Fixed Button Shadow Color Transparency Not Applied Correctly
by @NanthiniMahalingam in #29371
* Don't call NSAttributedString with HTML from a background thread by
@kubaflo in #26153
* [Windows] Implemented the Resize and Downsize functions in the
W2DImage class by @HarishwaranVijayakumar in
#29138
* Templated indicator view - improvements by @kubaflo in
#25642
* Update Issue25946.xaml by @anandhan-rajagopal in
#30025

## Testing
* Fixed Test case failure in PR 26153 - iOS by @kubaflo in
#29906
* Fixed Test case failure in PR 25642 - snapshots by @kubaflo in
#29881
* [Testing] Feature Matrix UITest Cases for RadioButton by
@TamilarasanSF4853 in #29744
* [Testing] Feature Matrix UITest Cases for CollectionView ItemsSource
Feature by @LogishaSelvarajSF4525 in
#29322
* [Testing] Feature Matrix UITest Cases for Stepper by
@nivetha-nagalingam in #29731
* [Testing] Feature Matrix UITest Cases for CheckBox Control by
@anandhan-rajagopal in #29739
* Update the comment for the test properties by @mattleibow in
#27306

## Dependency Updates
* No changes in this category

## Docs
* No changes in this category

## Housekeeping
* [create-pull-request] automated change by @github-actions[bot] in
#29875
* [create-pull-request] automated change by @github-actions[bot] in
#29792
* [create-pull-request] automated change by @github-actions[bot] in
#29760

**Full Changelog**:
origin/main...origin/inflight/candidate
rmarinho pushed a commit that referenced this pull request Jun 24, 2025
…Feature (#29322)

* added ItemsSource feature Tests

* modified changes

* updated changes

* Update src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/ItemsSource/CollectionViewItemsSourcePage.xaml.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* modified changes

* added snapshots

* modified changes

* modified changes

* modified changes

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2025
@ghost ghost added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Aug 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-collectionview CollectionView, CarouselView, IndicatorView area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants