[.NET 10] Add "Open/Close" API to picker controls #29323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/enhancement ☀️
PureWeen
requested changes
Jul 16, 2025
| /// <summary> | ||
| /// Provides event data for the event that is raised when a picker control is closed. | ||
| /// </summary> | ||
| public class PickerClosedEventArgs : EventArgs |
Member
There was a problem hiding this comment.
Let's break these out to all the separate types
- TimePickerClosed, DatePickerClosed, PickerClosed (same with open eventargs)
Look at creating a static "Empty" we can use internally as well to reduce allocations
Contributor
Author
There was a problem hiding this comment.
Ok, added all the new EventArgs.
github-project-automation
bot
moved this from Approved
to Changes Requested
in MAUI SDK Ongoing
github-project-automation
bot
moved this from Changes Requested
to Done
in MAUI SDK Ongoing
PureWeen
requested changes
Jul 18, 2025
github-project-automation
bot
moved this from In Progress
to Changes Requested
in MAUI SDK Ongoing
Member
|
Needs rebase @jsuarezruiz |
PureWeen
requested changes
Jul 22, 2025
| static Microsoft.Maui.Handlers.OpenWindowRequest.operator ==(Microsoft.Maui.Handlers.OpenWindowRequest? left, Microsoft.Maui.Handlers.OpenWindowRequest? right) -> bool | ||
| static Microsoft.Maui.Handlers.PickerHandler.MapIsOpen(Microsoft.Maui.Handlers.IPickerHandler! handler, Microsoft.Maui.IPicker! picker) -> void | ||
| static Microsoft.Maui.Handlers.SearchBarHandler.MapReturnType(Microsoft.Maui.Handlers.ISearchBarHandler! handler, Microsoft.Maui.ISearchBar! searchBar) -> void | ||
| static Microsoft.Maui.Handlers.TimePickerHandler.MapIsOpen(Microsoft.Maui.Handlers.ITimePickerHandler! handler, Microsoft.Maui.ITimePicker! timePicker) -> void |
Member
There was a problem hiding this comment.
can we just leave these all as internal for now?
going forward we're just going to leave these and extentions methods internal because they don't really add anything to make them public
Contributor
Author
There was a problem hiding this comment.
That static mapping method will end up being the only one not public in the Pickers, but, agree, let’s keep these and the related extension methods internal. Applied changes.
PureWeen
approved these changes
Jul 23, 2025
rmarinho
approved these changes
Jul 24, 2025
github-project-automation
bot
moved this from Changes Requested
to Approved
in MAUI SDK Ongoing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Changes in DatePicker, TimePicker and Picker:
IsOpen = trueopens the picker.IsOpen = falsecloses the picker.Events
Issues Fixed
Fixes #8945