-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS, Mac] Fix for Picker title is not displayed again when SelectedIndex is set to -1 #30486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rmarinho
merged 5 commits into
dotnet:inflight/candidate
from
HarishwaranVijayakumar:fix-30463
Aug 6, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ec2654d
Fix for Picker title not restoring after deselection on iOS
HarishwaranVijayakumar bdd3909
Modified test
HarishwaranVijayakumar be40042
Modified AutomationID
HarishwaranVijayakumar 0a263f9
Modified testcase
HarishwaranVijayakumar d3c0480
[tests] Add windows and mac snapshots
rmarinho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+25 KB
...ols/tests/TestCases.Android.Tests/snapshots/android/PickerShouldRegainTitle.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 30463, "Picker title is not displayed again", PlatformAffected.iOS)] | ||
| public class Issue30463 : ContentPage | ||
| { | ||
| public Issue30463() | ||
| { | ||
| VerticalStackLayout stackLayout = new VerticalStackLayout | ||
| { | ||
| Padding = 20, | ||
| Spacing = 10 | ||
| }; | ||
|
|
||
| Picker picker = new Picker | ||
| { | ||
| AutomationId = "RegainingPickerTitle", | ||
| Title = "Select an item", | ||
| ItemsSource = new List<string> { "Item 1", "Item 2", "Item 3" }, | ||
| SelectedIndex = 1 | ||
| }; | ||
|
|
||
| Button button = new Button | ||
| { | ||
| AutomationId = "ToggleSelectedIndexBtn", | ||
| Text = "Click to change selected index to -1" | ||
| }; | ||
| button.Clicked += (sender, e) => | ||
| { | ||
| picker.SelectedIndex = -1; | ||
| }; | ||
|
|
||
| stackLayout.Children.Add(picker); | ||
| stackLayout.Children.Add(button); | ||
| Content = stackLayout; | ||
| } | ||
| } | ||
|
|
Binary file added
BIN
+10.3 KB
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/PickerShouldRegainTitle.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions
21
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue30463.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
|
||
| public class Issue30463 : _IssuesUITest | ||
| { | ||
| public Issue30463(TestDevice device) : base(device) { } | ||
|
|
||
| public override string Issue => "Picker title is not displayed again"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.Picker)] | ||
| public void PickerShouldRegainTitle() | ||
| { | ||
| App.WaitForElement("ToggleSelectedIndexBtn"); | ||
| App.Tap("ToggleSelectedIndexBtn"); | ||
| VerifyScreenshot(); | ||
| } | ||
| } | ||
Binary file added
BIN
+8.47 KB
...trols/tests/TestCases.WinUI.Tests/snapshots/windows/PickerShouldRegainTitle.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+26.1 KB
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/PickerShouldRegainTitle.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.