Xaml Inflator parameters #30980
Merged
Xaml Inflator parameters #30980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
force-pushed
the
dev/stdelc/inflatorparameters
branch
4 times, most recently
from
6f828ce to
6d44bcb
Compare
StephaneDelcroix
force-pushed
the
dev/stdelc/inflatorparameters
branch
from
763f750 to
e4d4b6d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated XamlProcessingAttribute and associated public APIs from the XAML system, transitioning from attribute-based configuration to MSBuild metadata for specifying XAML inflators. The changes clean up the codebase by removing obsolete APIs and updating the unit test infrastructure to use the new MSBuild-based configuration approach.
- Removes
XamlProcessingAttributeand its usage across all test files - Updates build configuration to use MSBuild metadata for XAML inflator specification
- Cleans up unit test class accessibility modifiers and structure
Reviewed Changes
Copilot reviewed 271 out of 422 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Controls/src/Xaml/XamlProcessingAttribute.cs | Removes the entire XamlProcessingAttribute class |
| src/Controls/src/Xaml/XamlInflator.cs | Converts public enum to internal enum and removes documentation |
| src/Controls/src/Xaml/XamlCompilationAttribute.cs | Adds obsolete attributes and conditional compilation |
| src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj | Updates MSBuild configuration for XAML inflator specification |
| src/Controls/tests/Xaml.UnitTests/**/*.xaml.cs | Removes XamlProcessingAttribute usage and updates test class modifiers |
| src/Controls/src/Xaml/PublicAPI/**/*.txt | Updates public API surface to remove obsoleted types |
...ontrols/src/Build.Tasks/nuget/buildTransitive/netstandard2.0/Microsoft.Maui.Controls.targets
Show resolved
Hide resolved
StephaneDelcroix
force-pushed
the
dev/stdelc/inflatorparameters
branch
5 times, most recently
from
49cd145 to
a122733
Compare
PureWeen
added
the
p/0
StephaneDelcroix
force-pushed
the
dev/stdelc/inflatorparameters
branch
2 times, most recently
from
696c926 to
a46a6ca
Compare
jonathanpeppers
previously approved these changes
Aug 19, 2025
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
My comments were pretty minor, but it looked like one spot could throw a NRE.
|
|
||
| <ItemGroup> | ||
| <Compile Include="..\..\..\Core\tests\UnitTests\TestClasses\DispatcherStub.cs" Link="TestClasses\DispatcherStub.cs" /> | ||
| <!-- <Compile Remove="$(CompilerGeneratedFilesOutputPath)\**\*.cs" /> --> |
Member
There was a problem hiding this comment.
Suggested change
| <!-- <Compile Remove="$(CompilerGeneratedFilesOutputPath)\**\*.cs" /> --> |
Comment on lines
+9
to
+11
|
|
||
| <!-- <EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles> | ||
| <CompilerGeneratedFilesOutputPath>Generated</CompilerGeneratedFilesOutputPath> --> |
Member
There was a problem hiding this comment.
Suggested change
| <!-- <EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles> | |
| <CompilerGeneratedFilesOutputPath>Generated</CompilerGeneratedFilesOutputPath> --> |
StephaneDelcroix
changed the title
removes newly introduced XamlProcessing attribute in favor of msbuild item metadata. prepare the work to obsolete XamlCompilationAttribute too
StephaneDelcroix
force-pushed
the
dev/stdelc/inflatorparameters
branch
from
3eaa8d1 to
23c987e
Compare
Member
|
/backport to release/10.0.1xx-rc1 |
Contributor
|
Started backporting to release/10.0.1xx-rc1: https://github.com/dotnet/maui/actions/runs/17102222596 |
simonrozsival
approved these changes
Aug 20, 2025
github-project-automation
bot
moved this from Ready To Review
to Done
in MAUI SDK Ongoing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
replace the [XamlProcessing] attributes by msbuild metadata
Issues Fixed
Fixes #30877