Make IsActivated property public in Window.cs

[pictos]

Making this public will allow devs to filter and find the Window that has focus, it can make easier to show popups and perform some actions.

Related to #30762

Make IsActivated property public in Window.cs

The IsActivated property in the Microsoft.Maui.Controls namespace
was changed from internal to public. This increases its visibility,
allowing it to be accessed from outside the assembly.

[Copilot]

Pull Request Overview

This PR makes the IsActivated property in the Window class publicly accessible by changing its visibility from internal to public. This allows external consumers of the Microsoft.Maui.Controls API to check whether a window is currently activated.

• Changes the visibility modifier of the IsActivated property from internal to public

[rmarinho]

Needs to update public api files ?

[mattleibow]

For public properties, this really should be a bindable readonly property

Also

Can you add somrthing to the mutli-window sample page

• a binding to a label on that.

And maybe update/duplicate the tests here:

• src/Controls/tests/Core.UnitTests/WindowsTests.cs
• src/Controls/tests/DeviceTests/Elements/Window/WindowTests.Windows.cs

This is the wondow property on VisualElement, so ignore the name:

static readonly BindablePropertyKey WindowPropertyKey = BindableProperty.CreateReadOnly(
	nameof(Window), typeof(Window), typeof(VisualElement), null, propertyChanged: OnWindowChanged);

/// <summary>Bindable property for <see cref="Window"/>.</summary>
public static readonly BindableProperty WindowProperty = WindowPropertyKey.BindableProperty;

/// <summary>
/// Gets the <see cref="Window"/> that is associated with an element. This is a read-only bindable property.
/// </summary>
public Window Window => (Window)GetValue(WindowProperty);

/// <inheritdoc/>
Window IWindowController.Window
{
	get => (Window)GetValue(WindowProperty);
	set => SetValue(WindowPropertyKey, value);
}

I would expect something like this:

static readonly BindablePropertyKey IsActivatedPropertyKey = BindableProperty.CreateReadOnly(
	nameof(IsActivated), typeof(bool), typeof(Window), false);
public static readonly BindableProperty IsActivatedProperty = IsActivatedPropertyKey.BindableProperty;
public bool IsActivated
{
    get => (bool)GetValue(IsActivatedProperty)
    private set => SetValue(IsActivatedPropertyKey, value);
}

Also, we will need to remove the _isActivated field in window.cs.

[dotnet-policy-service]

Hi @@pictos. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.

[jfversluis]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[pictos]

BTW, is still missing DeviceTests, will implement it this week.
Can you remove the needs-author-input label?

[mattleibow]

This is great! Slowly bindable property-izing he world.

This will be nice to do binding to IsActivated.

Can you maybe also add a test for that using a binding to that property. Just to make sure that it does work.

[rmarinho]

Possible to add a DeviceTest ? clean up. the comment out code.

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[mattleibow]

/rebase

[mattleibow]

Matthew is super happy!

[mattleibow]

Bumped you to p/0, so you should get in the door for RC1.

[mattleibow]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[MartyIX]

This is a super useful change. Kudos @pictos.