Skip to content

Conversation

@jfversluis
Copy link
Member

Reverts #30488

Fixes #31139

Copilot AI review requested due to automatic review settings August 15, 2025 12:41
@jfversluis jfversluis requested a review from a team as a code owner August 15, 2025 12:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This is a revert commit that undoes the previous changes made in PR #30488, which exposed DispatcherExtensions for use outside of MAUI. The revert addresses issue #31139 by removing the public API exposure and moving the extension methods back to the Controls project.

  • Removes public DispatcherExtensions methods from the Core project's public API
  • Removes comprehensive unit tests for the reverted extension methods
  • Moves some dispatcher extension methods back to the Controls project with internal scope

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Core/tests/UnitTests/Dispatching/DispatcherTests.cs Removes NSubstitute dependency and all unit tests for DispatcherExtensions methods
src/Core/src/PublicAPI/net-tizen/PublicAPI.Unshipped.txt Removes public API entries for DispatcherExtensions methods
src/Core/src/Dispatching/DispatcherExtensions.cs Removes all DispatchIfRequired extension method implementations
src/Controls/src/Core/DispatcherExtensions.cs Adds back limited DispatchIfRequired methods with internal scope
Multiple platform files Removes unused Microsoft.Maui.Dispatching imports

: funcTask();
}

/// <summary>
Copy link

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This revert removes public DispatcherExtensions methods that were previously available in the public API. This represents a breaking change that should not be included in minor versions or service releases.

Copilot uses AI. Check for mistakes.
@jfversluis jfversluis added platform/windows p/0 Current heighest priority issues that we are targeting for a release. i/regression This issue described a confirmed regression on a currently supported version labels Aug 15, 2025
@jfversluis jfversluis added this to the .NET 10.0-rc1 milestone Aug 15, 2025
@jfversluis jfversluis merged commit 93923d7 into net10.0 Aug 15, 2025
129 checks passed
@jfversluis jfversluis deleted the revert-30488-issue-29258 branch August 15, 2025 19:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

i/regression This issue described a confirmed regression on a currently supported version p/0 Current heighest priority issues that we are targeting for a release. platform/windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants