-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Revert "Expose DispatcherExtensions so it could be used outside of Maui as well" #31184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ui as we…" This reverts commit b18db8b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This is a revert commit that undoes the previous changes made in PR #30488, which exposed DispatcherExtensions for use outside of MAUI. The revert addresses issue #31139 by removing the public API exposure and moving the extension methods back to the Controls project.
- Removes public
DispatcherExtensionsmethods from the Core project's public API - Removes comprehensive unit tests for the reverted extension methods
- Moves some dispatcher extension methods back to the Controls project with internal scope
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Core/tests/UnitTests/Dispatching/DispatcherTests.cs | Removes NSubstitute dependency and all unit tests for DispatcherExtensions methods |
| src/Core/src/PublicAPI/net-tizen/PublicAPI.Unshipped.txt | Removes public API entries for DispatcherExtensions methods |
| src/Core/src/Dispatching/DispatcherExtensions.cs | Removes all DispatchIfRequired extension method implementations |
| src/Controls/src/Core/DispatcherExtensions.cs | Adds back limited DispatchIfRequired methods with internal scope |
| Multiple platform files | Removes unused Microsoft.Maui.Dispatching imports |
| : funcTask(); | ||
| } | ||
|
|
||
| /// <summary> |
Copilot
AI
Aug 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This revert removes public DispatcherExtensions methods that were previously available in the public API. This represents a breaking change that should not be included in minor versions or service releases.
Reverts #30488
Fixes #31139