-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[MacCatalyst] DatePicker null date handling #31365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 31124, "DatePicker should maintain today's date when set to null", PlatformAffected.macOS)] | ||
| public class Issue31124 : ContentPage | ||
| { | ||
| DatePicker _datePicker; | ||
| Button _setNullButton; | ||
| Label _dateLabel; | ||
|
|
||
| public Issue31124() | ||
| { | ||
| InitializeComponent(); | ||
| } | ||
|
|
||
| void InitializeComponent() | ||
| { | ||
| Title = "DatePicker Null Test"; | ||
|
|
||
| _datePicker = new DatePicker | ||
| { | ||
| AutomationId = "TestDatePicker", | ||
| Date = DateTime.Today | ||
| }; | ||
|
|
||
| _setNullButton = new Button | ||
| { | ||
| Text = "Set Date to Null", | ||
| AutomationId = "SetNullButton" | ||
| }; | ||
| _setNullButton.Clicked += Button_Clicked; | ||
|
|
||
| _dateLabel = new Label | ||
| { | ||
| Text = $"Current Date: {_datePicker.Date:d}", | ||
| AutomationId = "DateLabel" | ||
| }; | ||
|
|
||
| // Listen for date changes to update the label | ||
| _datePicker.DateSelected += (s, e) => | ||
| { | ||
| _dateLabel.Text = $"Current Date: {e.NewDate:d}"; | ||
| }; | ||
|
|
||
| Content = new VerticalStackLayout | ||
| { | ||
| Padding = new Thickness(20), | ||
| Spacing = 20, | ||
| Children = | ||
| { | ||
| new Label { Text = "Test: Setting DatePicker.Date to null should remove today's date" }, | ||
| _datePicker, | ||
| _setNullButton, | ||
| _dateLabel, | ||
| new Label | ||
| { | ||
| Text = "Expected: After clicking button, date should be null", | ||
| FontSize = 12, | ||
| TextColor = Colors.Gray | ||
| } | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| void Button_Clicked(object sender, EventArgs e) | ||
| { | ||
| // Set datePicker.Date to null | ||
| _datePicker.Date = null; | ||
|
|
||
| // Update the label to show the current date | ||
| _dateLabel.Text = $"Current Date: {_datePicker.Date:d}"; | ||
| } | ||
| } | ||
54 changes: 54 additions & 0 deletions
54
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31124.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,54 @@ | ||||
| using System.Text.RegularExpressions; | ||||
|
||||
| using System.Text.RegularExpressions; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line will throw a NullReferenceException when _datePicker.Date is null. The format specifier :d cannot be applied to a null DateTime?. Consider using conditional formatting like
_datePicker.Date?.ToString("d") ?? "(null)"or similar null-safe approach.