[X] remove IElementNode interface #31559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the IElementNode interface which was identified as a premature optimization from 10 years ago. The goal is to revert this abstraction while there aren't too many conflicting branches, simplifying the codebase by directly using the ElementNode class instead of the interface.
- Removes the
IElementNodeinterface entirely from the XAML node hierarchy - Updates all references to use
ElementNodedirectly instead ofIElementNode - Modernizes code with C# language features (primary constructors, collection expressions, pattern matching improvements)
Reviewed Changes
Copilot reviewed 61 out of 61 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| XamlNode.cs | Removes IElementNode interface, updates ElementNode to implement interfaces directly |
| XmlName.cs | Converts to modern C# syntax with readonly struct and primary constructor |
| Multiple visitor files | Updates type references from IElementNode to ElementNode throughout the codebase |
| Test files | Removes mock IElementNode implementations that are no longer needed |
Comment on lines
42
to
51
| #if NETSTANDARD2_0 | ||
| if (NamespaceURI != null) | ||
| hashCode = NamespaceURI.GetHashCode(); | ||
| if (LocalName != null) | ||
| hashCode = (hashCode * 397) ^ LocalName.GetHashCode(); | ||
| int hashCode = 0; | ||
| if (NamespaceURI != null) | ||
| hashCode = NamespaceURI.GetHashCode(); | ||
| if (LocalName != null) | ||
| hashCode = (hashCode * 397) ^ LocalName.GetHashCode(); | ||
| return hashCode; | ||
| #else | ||
| if (NamespaceURI != null) | ||
| hashCode = NamespaceURI.GetHashCode(StringComparison.Ordinal); | ||
| if (LocalName != null) | ||
| hashCode = (hashCode * 397) ^ LocalName.GetHashCode(StringComparison.Ordinal); | ||
| return HashCode.Combine(NamespaceURI, LocalName); | ||
| #endif |
There was a problem hiding this comment.
The NETSTANDARD2_0 conditional compilation removes the use of StringComparison.Ordinal that was present in the original code. This could lead to culture-sensitive hash code generation on .NET Standard 2.0, potentially causing issues with hash table operations across different cultures.
simonrozsival
previously approved these changes
Sep 11, 2025
MartyIX
reviewed
Sep 11, 2025
that was a premature optimization 10 years ago, revert that while we don't have too many conflicting branches
StephaneDelcroix
force-pushed
the
dev/stdelc/hk_removeIElementNode
branch
from
6888f5d to
4e76f37
Compare
Co-authored-by: Šimon Rozsíval <simon@rozsival.com>
Co-authored-by: Šimon Rozsíval <simon@rozsival.com>
Co-authored-by: MartyIX <203266+MartyIX@users.noreply.github.com>
simonrozsival
approved these changes
Sep 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that was a premature optimization 10 years ago, revert that while we don't have too many conflicting branches