Separate snapshot diffs artifacts in CI #31724
Merged
+73
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
the
area-infrastructure
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the UI test pipeline to improve artifact publishing for snapshot diffs across multiple platforms. The changes extract snapshot diff collection logic into a reusable template and modernize the artifact publishing approach.
Key changes:
- Creates a new reusable template for collecting and publishing snapshot diff artifacts
- Replaces deprecated
PublishBuildArtifacts@1tasks with modernPublishPipelineArtifact@1 - Generates separate platform-specific artifacts instead of single combined artifacts
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/pipelines/common/ui-tests.yml | Adds template calls for snapshot diff collection across Android, iOS, Windows, and Mac platforms |
| eng/pipelines/common/ui-tests-steps.yml | Removes old inline snapshot diff publishing logic and adds comment about Notification Center |
| eng/pipelines/common/ui-tests-collect-snapshot-diffs.yml | New template implementing modernized snapshot diff collection and publishing logic |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
PureWeen
approved these changes
Sep 24, 2025
rmarinho
pushed a commit
that referenced
this pull request
Sep 29, 2025
* Update ui-tests-steps.yml * Fake test snapshot diff * Replace hardcoded tfm * Update ui-tests-steps.yml * Update ui-tests-steps.yml * Different approach * Update ui-tests.yml * Update ui-tests.yml * Update ui-tests.yml * Reusable template * Revert "Fake test snapshot diff" This reverts commit 99c982a. * Update eng/pipelines/common/ui-tests-collect-snapshot-diffs.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Also check files in subfolders --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> # Conflicts: # eng/pipelines/common/ui-tests.yml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the UI test pipeline steps to improve artifact publishing and snapshot diff validation across platforms. It also introduces a temporary UI change to help validate the new pipeline logic. The main changes are grouped below:
Pipeline improvements and artifact handling:
PublishBuildArtifacts@1task with the newerPublishPipelineArtifact@1for publishing snapshot diff artifacts for Android, iOS, Windows, and Mac (Catalyst) platforms, ensuring more robust and modern artifact handling.$(tfm)) from the build matrix instead of hardcodingnet9.0in artifact paths, making the pipeline more flexible and reducing maintenance overhead when frameworks change.After this change there are separate
uitests-snapshots-results-*artifacts that only have the diffs so that people don't have to download gigabytes of data just for some screenshots. See below.Screenshot taken from this build: https://dev.azure.com/xamarin/public/_build/results?buildId=151073&view=artifacts&pathAsName=false&type=publishedArtifacts