Skip to content

Conversation

@sheiksyedm
Copy link
Contributor

@sheiksyedm sheiksyedm commented Sep 24, 2025

This pull request makes a small but important change to the page navigation logic in NavigationPage.cs. The change improves the consistency and clarity of navigation event handling by updating the way the SendNavigating method is called.

  • The SendNavigating method in NavigationPage.cs is now called with both the navigationType and previousPage arguments, instead of just previousPage. This allows the navigation event to have more context and ensures consistent event ordering across all platforms.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Sep 24, 2025
@dotnet-policy-service
Copy link
Contributor

Hey there @@sheiksyedm! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Sep 24, 2025
@sheiksyedm sheiksyedm added the area-testing Unit tests, device tests label Sep 24, 2025
@rmarinho rmarinho merged commit b2abc39 into dotnet:net10_main_merge Sep 24, 2025
1 check passed
@PureWeen PureWeen mentioned this pull request Oct 21, 2025
2 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants