[ci] Fix helix local #31796
Merged
[ci] Fix helix local #31796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
added
the
area-infrastructure
rmarinho
added
area-testing
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with running Helix device tests locally and improves the documentation. The changes include correcting build commands, adding required environment variables, and reorganizing build configuration properties.
Key changes:
- Fixed documentation with proper build command syntax using
$(PWD)for correct project paths - Added required environment variables setup for Helix integration
- Reorganized build configuration to conditionally set properties based on access tokens
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/helix_xharness.proj | Moved and reorganized property settings for better conditional logic |
| docs/DevelopmentTips.md | Added clarifications and environment variable setup instructions |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Small fixes to be able to run locally, and improve documentation
This pull request updates the documentation and build configuration for running device tests locally and sending them to Helix. The main improvements clarify the setup steps, correct build commands, and introduce required environment variables for Helix integration.
Documentation improvements:
$(PWD)to ensure the correct project path is used.Build configuration updates:
TargetsAppleMobileproperty when targeting iOS, which helps configure Helix for Apple mobile platforms.TargetsAppleMobileto avoid duplication and ensure it only applies when the access token is not empty.