-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[net9.0] Clean up template options for the CLI #31848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request standardizes and improves the CLI template configuration for .NET MAUI project templates by cleaning up symbol definitions and controlling their visibility in the dotnet CLI. The changes ensure that internal version symbols are hidden from users while providing consistent naming conventions for user-facing options.
- Hidden internal version and configuration symbols to prevent them from appearing in CLI help
- Standardized symbol naming by adding
longNameproperties for consistency across templates - Improved user experience by hiding implementation details while preserving all functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
maui-multiproject/.template.config/dotnetcli.host.json |
Added hidden msExtensionsLoggingDebugVersion symbol and Framework longName |
maui-mobile/.template.config/dotnetcli.host.json |
Added hidden msExtensionsLoggingDebugVersion symbol and Framework longName |
maui-blazor/.template.config/dotnetcli.host.json |
Added hidden symbols and longName properties for Framework, IncludeSampleContent, and Empty |
maui-blazor-solution/.template.config/dotnetcli.host.json |
Comprehensive symbol configuration with hidden version/port symbols and standardized longName properties |
|
The reason for .NET 9 templates to fix .NET 10 is this:
|
|
/backport to release/9.0.1xx-sr12 |
|
Started backporting to release/9.0.1xx-sr12: https://github.com/dotnet/maui/actions/runs/18353556829 |
|
These chnages will be breaking and there is no need to break. for this. The ides and editors already hide it. This is semantics for the CLI. |
This pull request updates the
.template.config/dotnetcli.host.jsonfiles for several MAUI template projects to improve symbol configuration and control visibility of template options. The main changes involve marking certain template symbols as hidden, updating symbol descriptions, and standardizing symbol definitions across templates.Note
This is part of #23168. We have to update the .NET 9 templates because the CLI is a merge of all the installed template options. If .NET 9 uses bad options, then it flows through to .NET 10.
This does not affect the available options and all previous ones work, it just affects the "pretty" options.
Symbol visibility and configuration improvements:
msExtensionsLoggingDebugVersionsymbol and marked it as hidden in all affected templates to prevent it from appearing in user-facing options. [1] [2] [3] [4]IncludeSampleContentsymbol as hidden inmaui-blazor-solution,maui-blazor, andmaui-mobiletemplates to restrict its visibility. [1] [2] [3]maui-blazor-solution, including hiding symbols related to web components, ports, user secrets, and sample content, and providing long names for others to improve clarity.Frameworksymbol definition by adding alongNameproperty across all templates for consistency. [1] [2] [3] [4]Emptysymbol inmaui-blazor-solutionandmaui-blazortemplates to include alongNameproperty, clarifying its usage. [1] [2]Note
The formatting was bad, so review with ignoring whitespaces: https://github.com/dotnet/maui/pull/31848/files?w=1