Backport pipeline configuration fixes from PRs #32781 and #32803#32806
Closed
Copilot wants to merge 3 commits intorelease/10.0.1xxfrom
Closed
Backport pipeline configuration fixes from PRs #32781 and #32803#32806Copilot wants to merge 3 commits intorelease/10.0.1xxfrom
Copilot wants to merge 3 commits intorelease/10.0.1xxfrom
Conversation
Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Backport changes from PR 32781 and 32803
Backport pipeline configuration fixes from PRs #32781 and #32803
Nov 21, 2025
Member
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports critical pipeline configuration improvements from PRs #32781 and #32803 to enhance CI/CD reliability by consolidating variables, cleaning up storage token references, and updating feed URLs.
Key Changes:
- Simplified
_OfficialBuildIdArgsto empty string for public builds while maintaining full configuration for official internal builds - Removed redundant
DotNetBuilds storage account read tokensvariable group across all pipeline files (token now provided via provision step) - Changed from
Build.Reasonchecks to explicitBuild.DefinitionNamematching for more precise build definition identification
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/DotNet/DotNet.csproj | Updated DotNetFeedUrl from blob storage to ci.dot.net endpoint and corrected spacing in PrivateSdk property |
| eng/pipelines/maui-release-internal.yml | Removed DotNetBuilds storage account read tokens variable group |
| eng/pipelines/common/variables.yml | Removed _InternalBuildArgs variable, moved MAUI variable group outside conditional scope for consistent availability, and removed DotNetBuilds storage tokens |
| eng/pipelines/ci-official.yml | Removed DotNetBuilds storage account read tokens variable group (token now provided via provision step at line 102) |
| eng/pipelines/arcade/variables.yml | Simplified _OfficialBuildIdArgs to empty string for public builds, changed build checks from Build.Reason to explicit Build.DefinitionName matching for dotnet-maui and dotnet-maui-build pipelines |
The dotnetbuilds-internal-container-read-token variable from this group is needed by handlers.yml and other build steps for accessing internal feeds. Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Backports pipeline configuration improvements and storage token cleanup to improve CI/CD reliability, with adjustments for the target branch's authentication requirements.
Pipeline Variable Consolidation:
_OfficialBuildIdArgsto empty string for public buildsBuild.Reasonto explicitBuild.DefinitionNamematching_InternalBuildArgsvariable (no longer needed)Variable Group Cleanup:
DotNetBuilds storage account read tokensfrom ci-official.yml (redundant -dotnetbuilds-internal-container-read-token-base64provided via provision step)DotNetBuilds storage account read tokensin common/variables.yml (providesdotnetbuilds-internal-container-read-tokenvariable required by handlers.yml and build steps for internal feed access)DotNetBuilds storage account read tokensfrom maui-release-internal.ymlMAUIvariable group outside conditional scope for consistent availabilityFeed URL Update:
DotNetFeedUrlfromhttps://dotnetbuilds.blob.core.windows.net/publictohttps://ci.dot.net/publicPrivateSdkpropertyHelix Configuration:
Creatorproperty condition remains'$(HelixAccessToken)' == ''(PR [release/10.0.1xx-sr1] [ci] Revert changes setting Creator #32803 reverted the change from PR Backport pipeline configuration fixes from PRs #32610, #32694, #32779 #32781)Issues Fixed
Backport of: #32781, #32803
Note: This backport differs from the original PRs by retaining the
DotNetBuilds storage account read tokensvariable group in common/variables.yml. This is necessary for the target branch to maintain authentication for internal Azure DevOps feeds accessed during build steps.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.