Skip to content

Comments

Revert "[Android] Fixed Label Overlapped by Android Status Bar When Using SafeAreaEdges=\"Container\" in .NET MAUI"#33753

Merged
PureWeen merged 1 commit intorelease/10.0.1xx-sr3from
revert-pr-33285
Jan 28, 2026
Merged

Revert "[Android] Fixed Label Overlapped by Android Status Bar When Using SafeAreaEdges=\"Container\" in .NET MAUI"#33753
PureWeen merged 1 commit intorelease/10.0.1xx-sr3from
revert-pr-33285

Conversation

@PureWeen
Copy link
Member

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

This reverts PR #33285 which introduced changes to SafeAreaEdges handling on Android.

Reverted Changes

  • Removed test cases: Issue32941, Issue33034, Issue33038
  • Reverted SafeAreaExtensions.cs changes for detecting transitional views during Shell fragment animations
  • Removed associated test snapshots

Issues Re-opened

This revert will re-open:

Copilot AI review requested due to automatic review settings January 28, 2026 21:49
@PureWeen PureWeen changed the base branch from main to release/10.0.1xx-sr3 January 28, 2026 21:49
…sing SafeAreaEdges="Container" in .NET MAUI (#33285)"

This reverts commit 997fa31.
@PureWeen PureWeen merged commit 3c1c566 into release/10.0.1xx-sr3 Jan 28, 2026
1 of 12 checks passed
@PureWeen PureWeen deleted the revert-pr-33285 branch January 28, 2026 21:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the changes introduced in PR #33285, which attempted to fix SafeAreaEdges handling issues on Android during Shell fragment animations. The revert removes the logic that detected and handled transitional views extending beyond screen bounds, along with all associated test cases and snapshots.

Changes:

  • Removed the view bounds checking logic from SafeAreaExtensions.cs that handled Shell fragment transitions
  • Deleted three test case implementations (Issue32941, Issue33034, Issue33038)
  • Removed corresponding test files from the test host app

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Core/src/Platform/Android/SafeAreaExtensions.cs Removed transitional view detection logic that requested inset reapplication during Shell animations
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33038.cs Deleted test verifying layout correctness on first navigation
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33034.cs Deleted test verifying SafeAreaEdges work on all Shell tabs in landscape mode
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32941.cs Deleted test verifying label positioning to avoid status bar overlap
src/Controls/tests/TestCases.HostApp/Issues/Issue33038.cs Deleted test host implementation for Issue33038
src/Controls/tests/TestCases.HostApp/Issues/Issue33034.cs Deleted test host implementation for Issue33034
src/Controls/tests/TestCases.HostApp/Issues/Issue32941.cs Deleted test host implementation for Issue32941

evgenygunko pushed a commit to evgenygunko/CopyWordsDA that referenced this pull request Feb 4, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [Microsoft.Maui.Controls](https://github.com/dotnet/maui) | nuget | patch | `10.0.30` -> `10.0.31` |

---

### Release Notes

<details>
<summary>dotnet/maui (Microsoft.Maui.Controls)</summary>

### [`v10.0.31`](https://github.com/dotnet/maui/releases/tag/10.0.31): SR3.1

[Compare Source](dotnet/maui@10.0.30...10.0.31)

#### What's Changed

-   Increment patch version from 30 to 31 by [@&#8203;PureWeen](https://github.com/PureWeen) in dotnet/maui#33752
-   Revert "\[Android] Fixed Label Overlapped by Android Status Bar When Using SafeAreaEdges="Container" in .NET MAUI" by [@&#8203;PureWeen](https://github.com/PureWeen) in dotnet/maui#33753

**Full Changelog**: dotnet/maui@10.0.30...10.0.31

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or PR is renamed to start with "rebase!".

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
This was referenced Feb 4, 2026
This was referenced Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants