-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Font to Button and Entry #448
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee39526
to
b9250df
Compare
1866fbd
to
65e1007
Compare
hartez
approved these changes
Mar 11, 2021
I see this on the build logs, why don0't the other builds fail?
|
I'm guessing it's because Font is deprecated; we should be using UIButton.TitleLabel.Font. I'm fixing it now. |
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-controls-button
Button, ImageButton
area-controls-entry
Entry
area-controls-label
Label, Span
platform/android 🤖
platform/iOS 🍎
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Implements the
Font
property (family, size, attributes) onButton
andEntry
. After theIFont
was merged intoIText
in #416, we need to implement the other handlers that implementIText
.Additions made
Font
property map toButtonHandler
andEntryHandler
Font
mapping methods toButtonHandler
andEntryHandler
for Android and iOSFont
toButtonHandler
andEntryHandler
on Android and iOSFont
values toIButton
andIEntry
on iOS and AndroidPR Checklist