Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all GetAssemblies() implementations #4583

Merged
merged 3 commits into from
Feb 9, 2022
Merged

Remove all GetAssemblies() implementations #4583

merged 3 commits into from
Feb 9, 2022

Conversation

mattleibow
Copy link
Member

Description of Change

This PR just removes the remaining implementations and also the API from Device. The AppDomain is currently being used and this "feature" is not something we want to do going forward.

The GetAssemblies member on IPlatformServices was removed some time ago.

Part of #1965

Additions made

  • Removes the interface implementations for GetAssemblies
  • Removes Device.GetAssemblies

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the WinUI, Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

Was removed from IPlatformServices some time ago
@mattleibow mattleibow self-assigned this Feb 9, 2022
@mattleibow mattleibow added this to the 6.0.300-preview.14 milestone Feb 9, 2022
@Redth Redth merged commit 09faa7f into main Feb 9, 2022
@Redth Redth deleted the dev/get-assemblies branch February 9, 2022 21:18
@samhouts samhouts added the migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert label Aug 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants