-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to get the Android Control Gallery running again #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do we need Essentials in the sln ? Should we also add it to build again and make sure it builds? |
rmarinho
approved these changes
Mar 16, 2021
rmarinho
pushed a commit
that referenced
this pull request
Mar 16, 2021
* [Build] Remove old steps * Fix reference of unit tests cspro * Enable xaml unit tests * [Build] Add build of xaml unit tests * Try fix targets * Fix Forms naming * More naming fixes * Revert versions * Remove .Core * More .Core removals and Fix Platform references * Add RootNamespace to Build.Tasks * Fix more Xamarin.Forms old usage * Fix dll on build.targets * Fix _XFBuildTasksLocation * More fixes to _MauiBuildTasksLocation * More fixes _MauiBuildTasksLocation * Fix _MauiBuildTasksLocation * remove debug info * Remove issues for now * Rename maps namespace * Fix Assembly tests * Fix more targets * More map rename fixes * Fix xaml reference on unit tests * Fix MauiXamlCValidateOnly naming * More MauiXamlCValidateOnly * Add xaml page to sample * Fix namespace on sample page * oh, yeah * Fix sample references * Try run on release the xaml unit tests * Try continueOnerror * Update build-windows.yml * added via the directory props * ws * We mights need this * I think I did this * This can be reused * 🤦♀️ * this as well after the peppers PR * Fix some bad renames * i see * Fix merge * Fix sample * Remove FromSource * Add the packages * this * Yaysies! * Fix all the non-msbuild tests * Adding things back and gallery * this * Build the tasks first * Got the Android control gallery running * Fix diff after merge * - move gallery to compatibility * - namespaces updates * - rename compatibility * - another name * - keepass path * - wire up content description to AutomationID * - fix path * - fix ui tests path * - sln fixed * - xaml tests * - fix Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Try build ControlGallery Try build android controlgallery new path Fix Fix android uitests reference
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change