Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to get the Android Control Gallery running again #489

Merged
merged 76 commits into from
Mar 16, 2021

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented Mar 11, 2021

Description of Change

  • Moved the ControlGallery into the Compatibility folder
  • Updated the NameSpace on the ControlGallery to be Controls.Compatibility.ControlGallery (that's why so many changes)
  • Created a specific solution "Compatibility.ControlGallery.sln" to house the ControlGallery so our main solution doesn't get too burdened

@PureWeen PureWeen marked this pull request as ready for review March 13, 2021 22:27
@PureWeen PureWeen requested a review from rmarinho March 15, 2021 04:23
@rmarinho
Copy link
Member

Do we need Essentials in the sln ?

Should we also add it to build again and make sure it builds?

@rmarinho rmarinho merged commit 8037319 into main Mar 16, 2021
@PureWeen PureWeen deleted the dev/gallery-android branch March 16, 2021 15:03
rmarinho pushed a commit that referenced this pull request Mar 16, 2021
* [Build] Remove old steps

* Fix reference of unit tests cspro

* Enable xaml unit tests

* [Build] Add build of xaml unit tests

* Try fix targets

* Fix Forms naming

* More naming fixes

* Revert versions

* Remove .Core

* More .Core removals and Fix Platform references

* Add RootNamespace to Build.Tasks

* Fix more Xamarin.Forms old usage

* Fix dll on build.targets

* Fix _XFBuildTasksLocation

* More fixes to _MauiBuildTasksLocation

* More fixes _MauiBuildTasksLocation

* Fix _MauiBuildTasksLocation

* remove debug info

* Remove issues for now

* Rename maps namespace

* Fix Assembly tests

* Fix more targets

* More map rename fixes

* Fix xaml reference on unit tests

* Fix MauiXamlCValidateOnly naming

* More MauiXamlCValidateOnly

* Add xaml page to sample

* Fix namespace on sample page

* oh, yeah

* Fix sample references

* Try run on release the xaml unit tests

* Try continueOnerror

* Update build-windows.yml

* added via the directory props

* ws

* We mights need this

* I think I did this

* This can be reused

* 🤦‍♀️

* this as well after the peppers PR

* Fix some bad renames

* i see

* Fix merge

* Fix sample

* Remove FromSource

* Add the packages

* this

* Yaysies!

* Fix all the non-msbuild tests

* Adding things back and gallery

* this

* Build the tasks first

* Got the Android control gallery running

* Fix diff after merge

* - move gallery to compatibility

* - namespaces updates

* - rename compatibility

* - another name

* - keepass path

* - wire up content description to AutomationID

* - fix path

* - fix ui tests path

* - sln fixed

* - xaml tests

* - fix

Co-authored-by: Rui Marinho <me@ruimarinho.net>
Co-authored-by: Stephane Delcroix <stephane@delcroix.org>
Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>
Co-authored-by: Shane Neuville <shneuvil@microsoft.com>

Try build ControlGallery

Try build android controlgallery new path

Fix

Fix android uitests reference
@samhouts samhouts added the area-testing Unit tests, device tests label Jul 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants