[core] use StringComparison.Ordinal everywhere #4988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
force-pushed
the
StringComparisonOrdinal
branch
4 times, most recently
from
90c46f7
to
e11fe7d
Compare
StephaneDelcroix
approved these changes
Mar 1, 2022
|
The rules in the |
jonathanpeppers
force-pushed
the
StringComparisonOrdinal
branch
2 times, most recently
from
bf94fa4
to
f2f04bc
Compare
pranavkm
reviewed
Mar 1, 2022
Context: https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307 Context: https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1309 Context: dotnet/runtime#43956 I was reviewing `dotnet trace` output of the .NET Podcast app: 6.32ms Microsoft.Maui.Controls!Microsoft.Maui.Controls.ShellNavigationManager.GetNavigationState 3.82ms Microsoft.Maui.Controls!Microsoft.Maui.Controls.ShellUriHandler.FormatUri The bulk of this time is spent in `string.StartsWith()`, doing a culture-aware string comparison? 3.82ms System.Private.CoreLib!System.String.StartsWith 2.57ms System.Private.CoreLib!System.Globalization.CultureInfo.get_CurrentCulture This looks to be showing the cost of the 1st culture-aware comparision plus any time making these slower string comparisons. It would be ideal if project templates did not even hit `CultureInfo.get_CurrentCulture`. To solve this, let's add to the `.editorconfig` file: dotnet_diagnostic.CA1307.severity = error dotnet_diagnostic.CA1309.severity = error And then fix all the places errors appear. There are some complications in projects that use `netstandard2.0`: 1. For `Contains()` use `IndexOf()` instead. 2. Use `#if NETSTANDARD2_0` for `GetHashCode()` or `Replace()`. 3. Generally, `InvariantCulture` should not be used. After these changes, the `FormatUri` method disappears completely from the trace, and we instead get: 2.88ms Microsoft.Maui.Controls!Microsoft.Maui.Controls.ShellNavigationManager.GetNavigationState I suspect this saves ~3.44ms for any MAUI app startup, and a small amount more depending on the number of string comparisions happening.
jonathanpeppers
force-pushed
the
StringComparisonOrdinal
branch
from
f2f04bc
to
22944bf
Compare
Eilon
reviewed
Mar 1, 2022
| @@ -91,7 +91,7 @@ protected override async Task HandleWebResourceRequest(CoreWebView2WebResourceRe | |||
| { | |||
| relativePath = _hostPageRelativePath; | |||
| } | |||
| relativePath = Path.Combine(_contentRootDir, relativePath.Replace("/", "\\")); | |||
| relativePath = Path.Combine(_contentRootDir, relativePath.Replace('/', '\\')); | |||
Eilon
added
the
t/perf
samhouts
added
the
fixed-in-6.0.200-preview.14.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307
Context: https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1309
Context: dotnet/runtime#43956
I was reviewing
dotnet traceoutput of the .NET Podcast app:The bulk of this time is spent in
string.StartsWith(), doing aculture-aware string comparison?
This looks to be showing the cost of the 1st culture-aware comparision
plus any time making these slower string comparisons. It would be
ideal if project templates did not even hit
CultureInfo.get_CurrentCulture.To solve this, let's add to the
.editorconfigfile:And then fix all the places errors appear.
There are some complications in projects that use
netstandard2.0:For
Contains()useIndexOf()instead.Use
#if NETSTANDARD2_0forGetHashCode()orReplace().Generally,
InvariantCultureshould not be used.After these changes, the
FormatUrimethod disappears completely fromthe trace, and we instead get:
I suspect this saves ~3.44ms for any MAUI app startup, and a small
amount more depending on the number of string comparisions happening.