Made MaxLength property consistent across all platforms #5581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelkang
requested review from
PureWeen,
Redth,
hartez and
mattleibow
and removed request for
PureWeen
mattleibow
reviewed
Mar 25, 2022
Comment on lines
+102
to
+103
| if (maxLength == 0) | ||
| MauiAutoSuggestBox.SetIsReadOnly(platformControl, true); |
There was a problem hiding this comment.
Same as the text box below, does it re-enable after reverting MaxLength?
Comment on lines
+131
to
+132
| if (maxLength == 0) | ||
| textBox.IsReadOnly = true; |
There was a problem hiding this comment.
What happens if I set MaxLength to 0 nd then back to 10? Does it re-enable?
|
Tested iOS/MacCatalyst, working as expected, lgtm on those platforms! |
Redth
added
the
legacy-area-controls
|
AFAICT failing tests are unrelated |
|
Windows SearchBar MaxLength will need some more time #5669 |
mattleibow
reviewed
Apr 4, 2022
mattleibow
approved these changes
Apr 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
MaxLength property is now consistent across Windows, Android, and iOS for Entry, Editor, and SearchBar! yayyyy :)
MaxLength=-1 behaves as MaxLength=int.MaxValue
MaxLength=0 fields cannot be typed into
MaxLength>0 limits and trims text to the assigned value
Issues Fixed
Fixes #678