-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CharacterSpacing property in EntryHandlers #566
Implement CharacterSpacing property in EntryHandlers #566
Conversation
@@ -375,6 +375,7 @@ void UpdateText() | |||
Control.Text = text; | |||
} | |||
|
|||
[PortHandler] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would still need to port code related to the Placeholder
, could you add a comment here?
[PortHandler ("Partially ported ...")]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe that needs to be done in this PR? The Placeholder
property is already in the new handlers, so I think for this feature to be implemented completely, it needs to update the placeholder as well. Unless there is some specific reason why it can't be done now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side it makes sense also, I can do it in this PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattleibow since this was merged by hartez I will finish the Placeholder part in another PR :)
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description of Change
Implement
CharacterSpacing
property in EntryHandlers.Related issue #382
Platforms Affected
PR Checklist