-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Editor Placeholder text and color properties #573
Conversation
# Conflicts: # src/Core/src/Core/IEditor.cs # src/Core/src/Handlers/Editor/EditorHandler.Android.cs # src/Core/src/Handlers/Editor/EditorHandler.Standard.cs # src/Core/src/Handlers/Editor/EditorHandler.cs # src/Core/src/Handlers/Editor/EditorHandler.iOS.cs # src/Core/src/Platform/Android/EditorExtensions.cs # src/Core/src/Platform/iOS/EditorExtensions.cs # src/Core/tests/DeviceTests/Handlers/Editor/EditorHandlerTests.Android.cs # src/Core/tests/DeviceTests/Handlers/Editor/EditorHandlerTests.cs # src/Core/tests/DeviceTests/Handlers/Editor/EditorHandlerTests.iOS.cs # src/Core/tests/DeviceTests/Stubs/EditorStub.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very very nice! Thanks for this PR.
I just got one change, but other than that... Merges will happen!
|
||
namespace Microsoft.Maui.Platform.iOS | ||
{ | ||
public class MauiTextView : UITextView |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
I notice the placeholder is a bit off center... However, this seems to be an exact copy from Forms so might be a bug there. Not sure if we need to fix that here. But if it is an easy fix then maybe? Maybe @PureWeen knows? |
Description of Change
Implements #388
Additions made
PR Checklist