Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Font properties in PickerHandlers #589

Merged
merged 25 commits into from
Apr 7, 2021
Merged

Implement Font properties in PickerHandlers #589

merged 25 commits into from
Apr 7, 2021

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Mar 25, 2021 •
edited
Loading

Description of Change

Implement Font property in PickerHandlers.

Related issue #477

Platforms Affected

  • Core
  • iOS
  • Android

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

@rachelkang rachelkang self-requested a review March 25, 2021 15:44
rachelkang
rachelkang approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android tests all passing, and sample looks good
Still need to test on iOS

@PureWeen PureWeen self-requested a review April 5, 2021 18:42
mattleibow added 19 commits April 7, 2021 01:27
@mattleibow
Seems CheckBox is also done on Windows
924092b
@mattleibow
Added a enw attribute for incomplete handlers
ccb341a
@mattleibow
Clean up the handler code a tiny bit
a6890b1
@mattleibow
Use the new ITextStyle
6e1c6b0
@mattleibow
Fix tests
06f8e4f
@mattleibow
Do not fire text changed if nothing changed
dff6f23
@mattleibow
MaxLength == -1 crashes
01ba004
@mattleibow
MaxLines < 0 == everything
103d029
@mattleibow
Added a test
c8c6e72
@mattleibow
Attach that event!
6915a2a
@mattleibow
That is correct, 2 events
ebfda45
@mattleibow
Fix null ref
e367844
@mattleibow
Don't crash on -1 max length
7c85853
@mattleibow
nulls are uncool here
eb28089
@mattleibow
Re-apply the formatting
aadd73c
@mattleibow
Merge remote-tracking branch 'origin/main' into dev/handlers
4ad7689
@mattleibow
Test the crashes
c09e85a
@mattleibow
iOS is like Superman
330f36c 
It can do amazing things, sometimes... And that little green rock...
Apply the formatting after every change
Fire the text changed event when the text changes, but not when formatting changes
@mattleibow
No need to reset everything
2aaecfb
@mattleibow mattleibow changed the base branch from main to dev/handlers April 7, 2021 15:36
@mattleibow mattleibow marked this pull request as draft April 7, 2021 15:37
@mattleibow
Copy link
Member

Moved this to draft so we don't accidentally merge this one until we switch the base back to main. That other branch has a good few fixes that this might conflict with if we merge this first.

@mattleibow
Copy link
Member

I observed this bug #672 when reviewing this PR. I believe it is unrelated because we never set the placeholder at all.

@dotnet dotnet deleted a comment from azure-pipelines bot Apr 7, 2021
Base automatically changed from dev/handlers to main April 7, 2021 20:25
@mattleibow mattleibow marked this pull request as ready for review April 7, 2021 20:30
This was referenced Apr 7, 2021
Closed
Merged
@mattleibow mattleibow merged commit b83f98a into main Apr 7, 2021
@mattleibow mattleibow deleted the picker-font branch April 7, 2021 21:57
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@quasialaw quasialaw quasialaw approved these changes

@rachelkang rachelkang rachelkang approved these changes

@PureWeen PureWeen Awaiting requested review from PureWeen

Assignees

@PureWeen PureWeen

@rachelkang rachelkang

Labels
area-controls-picker Picker fixed-in-6.0.100-preview.3.5 platform/android 🤖 platform/iOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jsuarezruiz @mattleibow @rachelkang @quasialaw @Eilon @PureWeen @samhouts