[Handlers] Make sure to update Content on handlers when the ControlTemplate changes #7235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
the
legacy-area-controls
PureWeen
reviewed
May 17, 2022
Member
Author
|
Added the test @PureWeen |
PureWeen
reviewed
May 18, 2022
| protected override void OnApplyTemplate() | ||
| { | ||
| Handler?.UpdateValue(nameof(Content)); | ||
| base.OnApplyTemplate(); |
Member
There was a problem hiding this comment.
Can we swap the order of these two?
I realize base.OnApplyTemplate is currently empty but it just feels like logically you'd want the UpdateValue call to happen after OnApplyTemplate
PureWeen
reviewed
May 18, 2022
# Conflicts: # src/Controls/tests/DeviceTests/HandlerTestBase.cs
PureWeen
approved these changes
May 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Handlers use the
PresentedContentto get the content to renderer, but when the template changes nothing was calling a mapper that used that property.Since there are some TemplateUtilities that run on ContentTemplateChange the order to call MapContent is important, it should be after all the TemplateUtilities logic run, so the best way without changing existing Controls code is on the ApplyTemplate
Issues Fixed
Fixes #4135