-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement .NET MAUI Maps #7886
Implement .NET MAUI Maps #7886
Conversation
Is this for the new apple maps just announced or just the old maps |
This is porting over Xamarin.Forms Maps to .NET MAUI. Nothing new needs to be done for the new Apple Maps stuff. |
# Conflicts: # src/Core/src/Handlers/ScrollView/ScrollViewHandler.iOS.cs # src/Core/src/Layouts/GridLayoutManager.cs # src/Core/src/Platform/iOS/SearchBarExtensions.cs # src/Templates/src/templates/maui-blazor/MauiApp.1.csproj
src/Compatibility/ControlGallery/src/Core/GalleryPages/MapElementsGallery.xaml.cs
Show resolved
Hide resolved
@@ -212,16 +214,16 @@ protected override void OnLayout(bool changed, int l, int t, int r, int b) | |||
{ | |||
if (NativeMap != null) | |||
{ | |||
MoveToRegion(Element.LastMoveToRegion, false); | |||
// MoveToRegion(Element.LastMoveToRegion, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LastMoveToRegion have been removed?
if (googleMap == null) | ||
return; | ||
|
||
googleMap.MapType = map.MapType switch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not essential, but could we move this to extension methods like in other Handlers? This way, someone extending the Handler could easily access this logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sky41906
Description of Change
Adding handlers for maps
Removed API:
Position
- Replaced byMicrosoft.Maui.Devices.Sensors.Location
Geocoder
- Replaced byMicrosoft.Maui.Devices.Sensors.Geocoding
GeographyUtils
MoveToLastRegionOnLayoutChange
on `MapMap
remove EditorBrowsable APIsChanged API:
Microsoft.Maui.Controls.Maps.Position
on Pin toMicrosoft.Maui.Devices.Sensors.Location
Microsoft.Maui.Controls.Maps.Position
on MapClickedEventArgs toMicrosoft.Maui.Devices.Sensors.Location
Microsoft.Maui.Controls.Maps.Position
Center on MapSpan toMicrosoft.Maui.Devices.Sensors.Location
Microsoft.Maui.Controls.Maps.Position
Geopath on Polyline toMicrosoft.Maui.Devices.Sensors.Location
Microsoft.Maui.Controls.Maps.Position
Geopath on Polygon toMicrosoft.Maui.Devices.Sensors.Location
TrafficEnabled
toHasTrafficEnabled
Position
toLocation
New API:
Issues Fixed
Fixes #3933