[android] fix MauiSplashScreen on Android 12+ #8394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#7404 Context: https://developer.android.com/guide/topics/ui/splash-screen#set-theme Reviewing a lot of the feedback around splash screens, I tried: 1. Rename `splash.svg` to `splash2.svg` 2. Change the .NET splash logo from white to blank. I found these changes worked fine on Android < 12, but I did not see my changes on Android 12+! This was more troubling when I changed the `MauiSplashScreen` `Color` to white. After some review, it looks like we need to define: <item name="android:windowSplashScreenBackground">@color/maui_splash_color</item> <item name="android:windowSplashScreenAnimatedIcon">@drawable/maui_splash</item> With these changes in place, the splash screen is working for me in Android 12+. I believe we implemented `MauiSplashScreen` while Android 12 was still in beta, so we just didn't notice this behavior. We also were sharing the same `.svg` file for the app icon and splash screen previously, which may have confused or hidden this issue.
Eilon
added
the
area-single-project
mattleibow
approved these changes
Jun 30, 2022
This was referenced Aug 30, 2022
|
Where is the styles.xml file located on my local machine? I'm new to .net maui and can't seem to find it. |
|
Same issue, Will this display full screen image in splash screen? @jonathanpeppers |
|
This is the new feature of Android 12+. No more full screens. Maybe they will revert in Android 14, who knows. Maybe the only way is to file a bug with the Android SDK. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7404
Context: https://developer.android.com/guide/topics/ui/splash-screen#set-theme
Reviewing a lot of the feedback around splash screens, I tried:
splash.svgtosplash2.svgI found these changes worked fine on Android < 12, but I did not see
my changes on Android 12+!
This was more troubling when I changed the
MauiSplashScreenColorto white:
After some review, it looks like we need to define:
With these changes in place, the splash screen is working for me in
Android 12+, I tested a new project and changed the color of the .NET logo:
I believe we implemented
MauiSplashScreenwhile Android 12 was stillin beta, so we just didn't notice this behavior. We also were sharing
the same
.svgfile for the app icon and splash screen previously,which may have confused or hidden this issue.