Fix DatePicker on Android so that it can GC #8505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
PureWeen
commented
Jul 4, 2022
src/Core/tests/DeviceTests/Handlers/HandlerTestBaseOfT.Tests.cs
Outdated
Show resolved
Hide resolved
Eilon
added
the
legacy-area-controls
PureWeen
force-pushed
the
fix_datepicker_android_leak
branch
from
6ffd96e
to
5610d54
Compare
PureWeen
force-pushed
the
fix_datepicker_android_leak
branch
from
aaa222e
to
42da4e3
Compare
mattleibow
reviewed
Jul 19, 2022
mattleibow
approved these changes
Jul 19, 2022
Eilon
added
area-controls-datetimepicker
samhouts
added
fixed-in-7.0.0-rc.1.6683
fixed-in-6.0.486
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Only subscribe to the display changed when control is connected to the window. Once it's removed from the window unsubscribe otherwise the handler will leak
Moved the allocation tests out to a separate collection of tests that's able to run as two parts. I found that if you leave the frame of the test and then check the allocation later the GC will have more opportunity to collect. This was needed to get the tests working on API 30 and WinUI.