fix tests #8672
Merged
fix tests #8672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
approved these changes
Jul 12, 2022
jsuarezruiz
approved these changes
Jul 12, 2022
Eilon
reviewed
Jul 12, 2022
| @@ -1851,6 +1851,8 @@ public void SetBindingContextAfterInnerBindingsAndContextBinding() | |||
| [Test] | |||
| public void Convert() | |||
| { | |||
| System.Threading.Thread.CurrentThread.CurrentCulture = System.Threading.Thread.CurrentThread.CurrentUICulture = CultureInfo.InvariantCulture; | |||
There was a problem hiding this comment.
Hold on - is this a bug in the test, or a bug in the product? I think there are many places in Xamarin.Forms and MAUI where the product code is using CurrentCulture to parse/format strings, where it should be using Invariant/Ordinal. Not sure if that's the case here.
There was a problem hiding this comment.
no need to hold on here. it's an issue in the test. The next test in that file is named ConvertIsCultureAware and is testing this, precisely
Eilon
added
the
area-infrastructure
samhouts
added
fixed-in-6.0.540
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Somehow this version of VSMac doesn't run tests in the InvariantCulture, so the test was failing on the text<->double conversions