Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disconnect old handler after setting new handler #8781

Merged
merged 8 commits into from
Aug 8, 2022
Merged

Disconnect old handler after setting new handler #8781

merged 8 commits into from
Aug 8, 2022

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Jul 16, 2022 •
edited
Loading

Description of Change

  • When a handler is set to null on a virtual view call "disconnecthandler" on the previous handler
  • When a new handler is being set on a VirtualView call "Disconnecthandler" on the previous handler. This is primarily useful on Android where various scenarios will cause the "Activity" to recreate which means we have to recreate everything. So, as the everything passes through we need to make sure to "Disconnect" from the previous handlers.

Issues Fixed

Fixes #8456

@PureWeen PureWeen force-pushed the disconnect_previous_handler branch from fa30904 to 01b61dc Compare July 19, 2022 21:43
@PureWeen PureWeen marked this pull request as ready for review July 20, 2022 15:06
@PureWeen PureWeen linked an issue Jul 20, 2022 that may be closed by this pull request
Deal with the scenario of a handler on a virtual view being set to a new handler. #8456
Closed
@PureWeen PureWeen force-pushed the disconnect_previous_handler branch from 01b61dc to 10c36ca Compare July 21, 2022 21:09
@Eilon Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Aug 1, 2022
@PureWeen PureWeen added this to the .NET 7 milestone Aug 5, 2022
@PureWeen PureWeen changed the base branch from net6.0 to main August 5, 2022 17:04
@PureWeen PureWeen force-pushed the disconnect_previous_handler branch from fdc44dc to 654dcdb Compare August 5, 2022 17:16
@mattleibow mattleibow merged commit 324731f into main Aug 8, 2022
@mattleibow mattleibow deleted the disconnect_previous_handler branch August 8, 2022 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

Assignees
No one assigned
Labels
fixed-in-7.0.0-rc.1.6683 legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor
Projects
None yet
Milestone
.NET 7 + Servicing
Development

Successfully merging this pull request may close these issues.

Deal with the scenario of a handler on a virtual view being set to a new handler.
4 participants
@PureWeen @mattleibow @Eilon @samhouts