Pin net6 branch #9051
Merged
Pin net6 branch #9051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
Jul 28, 2022
| @@ -5,5 +5,10 @@ | |||
| "msbuild-sdks": { | |||
| "MSBuild.Sdk.Extras": "3.0.44", | |||
| "Microsoft.Build.NoTargets": "3.3.0" | |||
| }, | |||
| "sdk": { | |||
| "version": "6.0.302", | |||
There was a problem hiding this comment.
If you set this to 6.0.400-preview CI fails because CI only has GA installed which is 6.0.302
Once 6.0.400 is GA then we can bump.
There was a problem hiding this comment.
hum, how is this updated with new sdk bumps coming from maestro? we install local versions of dotnet and workloads,
There was a problem hiding this comment.
It doesn't really matter because I set
"rollForward": "latestMinor"
So dotnet is going to resolve to whatever the newest pre 7 version is.
If you pull down this PR and run
dotnet --version
It'll return 6.0.400-previewXXXX
Eilon
added
the
area-infrastructure
rmarinho
approved these changes
Aug 1, 2022
mattleibow
approved these changes
Aug 1, 2022
samhouts
added
fixed-in-6.0.540
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Pin NET6 branch top NET6 so when NET7 is installed we can still compile