Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public triage information #9136

Merged
merged 7 commits into from
Aug 5, 2022
Merged

Add public triage information #9136

merged 7 commits into from
Aug 5, 2022

Conversation

jfversluis
Copy link
Member

@jfversluis jfversluis commented Aug 2, 2022

Description of Change

Adds our public triage information so it's clear for everyone how our process works.
Additionally I've added rules to the Fabric bot to better support this new flow and the process altogether.

See inline comments for important parts and if you're a maintainer; please read through the whole thing :)

@@ -1,6 +1,6 @@
name: Bug Report
description: File a bug report
labels: ["t/bug", "s/needs-verification"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since our only filter for triage is now basically going to be: is it on a milestone? We could opt for no initial label at all and add it during triage. That way it's also clear that we actually identified it as a bug.

Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, this seems implicit. If it doesn't have "verified" than it needs verification

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But same for bug? Should we only label it as a bug if we actually find it to be a bug instead of applying that simply when the issue is opened?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think because it's the "bug" template then labeling as "bug" is reasonable. Of course sometimes it turns out to be wrong, but I'd consider it a strong indicator.

{
"name": "addLabel",
"parameters": {
"label": "i/great-reporter"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the i/great-reporter label for issue reporters who have a good track record authoring issues on our repo.

{
"name": "labelAdded",
"parameters": {
"label": "s/try-latest-version"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a "please try latest version" label so we can easily instruct people to please try again on the latest version. Please review the description just below if it's clear enough or it needs work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this. We need to be careful to apply it only to issues that are fixed in public releases, as opposed to "we merged the fix last night so good luck building the MAUI repo and using it in your app."

}
}
],
"taskName": "[Idle Issue Management] Close stale 's/try-latest-version' issues",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close the "please try latest version" labeled issues if no response comes within 7 days

"issues",
"project_card"
],
"taskName": "Add 'community ✨' label to community contributions",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically add the community label to opened PRs so we can prioritize those

}
}
],
"taskName": "Stale PR reminder",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark PRs as stale after 10 days if we requested author input

}
}
],
"taskName": "Close stale PRs",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close stale PRs after 14 days if we requested author input but nothing has happened since

"issues",
"project_card"
],
"taskName": "Revitalize stale PR and reopen",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If author of a stale PR does update the PR remove the stale label(s)

"issues",
"project_card"
],
"taskName": "Add comment when 's/pr-needs-author-input' is applied to PR",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a friendly comment to the author of the PR that we need some info/action from their side when we add this label

@jfversluis jfversluis requested a review from Eilon August 2, 2022 13:33
@jfversluis jfversluis added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Aug 2, 2022
If the author does not post a response within **7 days**, the issue will be automatically closed. If the author responds within **7 days** after the issue is closed, the issue will be automatically re-opened. We recognize that you may not be able to respond immediately to our requests, we're happy to hear from you whenever you're able to provide the new information.

### PR: pending author input
Similar to the `Needs Author Feedback` process above, PRs also require author input from time to time. When a member of our team asks for some follow-up changes from the author, we mark these PRs with `s/pr-needs-author-input` label. After doing so, we expect the author to respond within 14 days.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New label to let the PR author know we are waiting for input and stale PRs will be closed


### Feature requests

As soon as we identify an issue represents an ask for a new feature, we will label the issue with the `t/enhancement ☀️` label.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooks into the comment on the bug report template: Should we not add any labels by default at all?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the "bug" label, I think if we have specific templates for bug, feature request, etc. then we might as well apply the label in the template. We can always change the labels if they're incorrect.


### Investigations

In many situations it's not immediately clear whether a specific issue reported is a bug or not. To be certain, the team will need to spend time to investigate it before making a call regarding the faith of the issue. In these situations we will apply the `investigate` label to the issue.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's slap the investigate label on so we know we need to investigate more first, this can then happen in a sprint rather than at triage.

@jfversluis jfversluis marked this pull request as ready for review August 3, 2022 13:23
Copy link
Member

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't read all the fabricbot json changes but overall this seems good to me.

@jfversluis jfversluis merged commit ad835e4 into main Aug 5, 2022
@jfversluis jfversluis deleted the add-public-triage branch August 5, 2022 08:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions fixed-in-7.0.0-rc.1.6683 t/housekeeping ♻︎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants