Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate semantic properties from FlyoutItem #9270

Merged
merged 8 commits into from
Aug 22, 2022
Merged

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Aug 8, 2022

Description of Change

  • Propagate any SemanticProperties set to the templated Grid created inside the FlyoutItems.
  • Fix a few spots on WinUI where it would Tab to empty content. I've disabled the TabStop for the templated content controls used to render the flyoutitems and the flyout footer. This way it now tabs directly to the actual content. By default the Navigation items on the WinUI NavigationView can be navigated via arrow keys not by tab.
    • One thing to note here is that navigating via tab/arrow keys is broken on WinUI if you do it with a debugger attached. So, after you've launched your code stop the debugger and then re-launch the app to test

Issues Fixed

Fixes #9066

@PureWeen PureWeen requested a review from rachelkang August 8, 2022 17:16
@@ -281,8 +279,6 @@ public Element Element
if (_element != null)
{
_shell.AddLogicalChild(View);
AutomationPropertiesProvider.AccessibilitySettingsChanged(_itemView, value);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now propagated through SemanticProperties bindings

@PureWeen PureWeen force-pushed the flyout_accessibility branch from e87c12b to e194c76 Compare August 8, 2022 22:45
@PureWeen PureWeen force-pushed the flyout_accessibility branch from e194c76 to 8c5bd69 Compare August 18, 2022 17:42
Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As shared offline, the current behavior I'm noticing is as follows:

  • Narrator announces invisible/nonexistent images for each of the flyout items
  • Narrator reads the flyout item text twice - both on the item, and the text label itself
  • Keyboard navigation doesn't work as expected

That being said, the core issue is indeed fixed! The flyout item text is read aloud for how it's shown on the UI, and not based on the name of the control behind the scenes

@PureWeen PureWeen requested a review from rachelkang August 18, 2022 19:44
@PureWeen
Copy link
Member Author

@rachelkang should be fixed can you try again?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants