-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate semantic properties from FlyoutItem #9270
Conversation
@@ -281,8 +279,6 @@ public Element Element | |||
if (_element != null) | |||
{ | |||
_shell.AddLogicalChild(View); | |||
AutomationPropertiesProvider.AccessibilitySettingsChanged(_itemView, value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now propagated through SemanticProperties
bindings
e87c12b
to
e194c76
Compare
e194c76
to
8c5bd69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As shared offline, the current behavior I'm noticing is as follows:
- Narrator announces invisible/nonexistent images for each of the flyout items
- Narrator reads the flyout item text twice - both on the item, and the text label itself
- Keyboard navigation doesn't work as expected
That being said, the core issue is indeed fixed! The flyout item text is read aloud for how it's shown on the UI, and not based on the name of the control behind the scenes
@rachelkang should be fixed can you try again? |
Description of Change
SemanticProperties
set to the templatedGrid
created inside the FlyoutItems.Issues Fixed
Fixes #9066