Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves Microsoft.Maui.Graphics.Gtk into the Maui repo #9522

Closed

Conversation

lytico
Copy link
Contributor

@lytico lytico commented Aug 18, 2022

Description of Change

Moves Microsoft.Maui.Graphics.Gtk into the Maui repo

history:
dotnet/Microsoft.Maui.Graphics#469
dotnet/Microsoft.Maui.Graphics#112
dotnet/Microsoft.Maui.Graphics#78

Issues Fixed

fixes #8694

@ghost ghost added the community ✨ Community Contribution label Aug 18, 2022
@ghost
Copy link

ghost commented Aug 18, 2022

Hey there @lytico! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jsuarezruiz jsuarezruiz added the area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing label Aug 18, 2022
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just got a few comments to make the updating of the versions and new dotnet versions easier.

src/Graphics/src/Graphics.Gtk/Extras/LineBreakMode.cs Outdated Show resolved Hide resolved
src/Graphics/src/Graphics.Gtk/Graphics.Gtk.csproj Outdated Show resolved Hide resolved
src/Graphics/src/Graphics.Gtk/Graphics.Gtk.csproj Outdated Show resolved Hide resolved
src/Graphics/src/Graphics.Gtk/Graphics.Gtk.csproj Outdated Show resolved Hide resolved
@mattleibow
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mattleibow mattleibow self-assigned this Aug 19, 2022
@mattleibow mattleibow added this to the .NET 7 Planning milestone Aug 19, 2022
@mattleibow
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rmarinho
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@MartyIX
Copy link
Contributor

MartyIX commented Jun 13, 2023

Is this a step towards supporting MAUI on linux? Could anyone explain please?

@PureWeen PureWeen removed their assignment Jun 21, 2023
@samhouts samhouts removed this from the .NET 8 Planning milestone Jul 26, 2023
@samhouts samhouts added this to the Under Consideration milestone Aug 15, 2023
@samhouts samhouts added the stale Indicates a stale issue/pr and will be closed soon label Sep 11, 2023
@lytico
Copy link
Contributor Author

lytico commented Sep 13, 2023

@samhouts why stale?

@PureWeen
Copy link
Member

PureWeen commented Jun 5, 2024

Closing this PR for now.

We aren't going to be able to invest time into reviewing and merging this currently.

We have an issue here to track interest. If we get time to schedule this for an upcoming milestone we'll reopen this PR.

@PureWeen PureWeen closed this Jun 5, 2024
@YoshiRulz
Copy link

Please understand that ghosting the author of a high-profile PR for 9 months and then unceremoniously closing it is not a good look.

@samhouts samhouts removed this from the Under Consideration milestone Jul 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing community ✨ Community Contribution stale Indicates a stale issue/pr and will be closed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Microsoft.Maui.Graphics.Gtk into the Maui repo
8 participants