Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up scene life cycle events #9525

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Wire up scene life cycle events #9525

merged 2 commits into from
Aug 19, 2022

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Aug 18, 2022

Description of Change

When we added scenes we didn't add the relevant life cycle hooks related to scenes. This means that most of the xplat window events on iOS currently aren't firing

Issues Fixed

Fixes #9476

API Changes

Maui.Core

namespace Microsoft.Maui.LifecycleEvents
{
	public static class iOSLifecycle
	{
		// Scene
		public delegate void SceneWillEnterForeground(UIScene scene);
		public delegate void SceneOnActivated(UIScene scene);
		public delegate void SceneOnResignActivation(UIScene scene);
		public delegate void SceneDidEnterBackground(UIScene scene);
		public delegate bool SceneOpenUrl(UIScene scene, NSSet<UIOpenUrlContext> urlContexts);
		public delegate bool SceneContinueUserActivity(UIScene scene, NSUserActivity userActivity);
		public delegate void SceneWillContinueUserActivity(UIScene scene, string userActivityType);
		public delegate void SceneDidFailToContinueUserActivity(UIScene scene, string userActivityType, NSError error);
		public delegate void SceneDidUpdateUserActivity(UIScene scene, NSUserActivity userActivity);
		public delegate void SceneRestoreInteractionState(UIScene scene, NSUserActivity stateRestorationActivity);
	}
}
namespace Microsoft.Maui
{
	[System.Runtime.Versioning.SupportedOSPlatform("ios13.0")]
	[System.Runtime.Versioning.SupportedOSPlatform("tvos13.0")]
	public class MauiUISceneDelegate : UIResponder, IUIWindowSceneDelegate
	{
		[Export("sceneWillEnterForeground:")]
		public virtual void WillEnterForeground(UIScene scene);

		[Export("sceneDidBecomeActive:")]
		public virtual void OnActivated(UIScene scene);

		[Export("sceneWillResignActive:")]
		public virtual void OnResignActivation(UIScene scene);

		[Export("sceneDidEnterBackground:")]
		public virtual void DidEnterBackground(UIScene scene) ;

		[Export("scene:openURLContexts:")]
		public virtual bool OpenUrl(UIScene scene, NSSet<UIOpenUrlContext> urlContexts);

		[Export("scene:continueUserActivity:")]
		public virtual bool ContinueUserActivity(UIScene scene, NSUserActivity userActivity);

		[Export("scene:willContinueUserActivityWithType:")]
		public void WillContinueUserActivity(UIScene scene, string userActivityType);

		[Export("scene:didFailToContinueUserActivityWithType:error:")]
		public void DidFailToContinueUserActivity(UIScene scene, string userActivityType, NSError error);


		[Export("scene:didUpdateUserActivity:")]
		public void DidUpdateUserActivity(UIScene scene, NSUserActivity userActivity);

		[Export("scene:restoreInteractionStateWithUserActivity:")]
		public void RestoreInteractionState(UIScene scene, NSUserActivity stateRestorationActivity);

@PureWeen PureWeen marked this pull request as ready for review August 18, 2022 16:04
@PureWeen PureWeen marked this pull request as draft August 18, 2022 16:13
@PureWeen PureWeen marked this pull request as ready for review August 18, 2022 16:42
- just use IUIWindowSceneDelegate delegate
@PureWeen PureWeen requested a review from mattleibow August 19, 2022 14:25
@mattleibow mattleibow merged commit 9bb3d14 into main Aug 19, 2022
@mattleibow mattleibow deleted the wire_up_scene branch August 19, 2022 22:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing LifeCycle events for SceneDelegate on iOS and MacCatalyst
4 participants