Remove GetEffectiveFlowDirection and defer flow direction handling to platforms #9558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Leaving this as draft until I can get around to updating all the public API files and removing the now-unused extension methods. |
hartez
force-pushed
the
remove-geteffectiveflowdirection
branch
2 times, most recently
from
a9a6985 to
607086b
Compare
PureWeen
reviewed
Aug 25, 2022
| @@ -45,9 +45,6 @@ public partial class EntryHandler : IEntryHandler | |||
|
|
|||
| static EntryHandler() | |||
There was a problem hiding this comment.
Can we just delete the entire static ctor now?
Same question for LabelHandler/LayoutHandler/PickerHandler/SearchBarHandler
|
@hartez the arranging on CollectionView looks to be better now but the sizing seems off now in RTL mode The Left image is this PR
|
|
Hmmm... the problems on Android in the CollectionView go away if I remove the Border from the template. |
|
@PureWeen The Android problems should be fixed - looking at the iOS issues now. |
… platforms; Automate reversal of RTL layouts during platform arrange;
hartez
force-pushed
the
remove-geteffectiveflowdirection
branch
from
d4ae573 to
8ccaa7f
Compare
PureWeen
approved these changes
Aug 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Automates reversal of RTL layouts during platform arrange for iOS and Android (basically works like Windows now).
Removes all cross-platform RTL layout code (since the platforms handle it). Updates automated tests accordingly.
Propagates iOS LTR/RTL settings when FlowDirection is MatchParent (this wasn't happening at all before).
Consolidates code to update text alignment on iOS when FlowDirection changes.
Adds FlowDirection propagation tests for iOS (skips the other platforms because they do this automatically).
Issues Fixed
Fixes #8175 (in that it removes
ShouldArrangeLeftToRightentirely).This is an alternative to #9326/#9327.