Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in ScrollToRequest.cs #9574

Closed
wants to merge 1 commit into from

Conversation

lindexi
Copy link
Member

@lindexi lindexi commented Aug 22, 2022

Description of Change

Just fix the typo.

@ghost ghost added the community ✨ Community Contribution label Aug 22, 2022
@ghost
Copy link

ghost commented Aug 22, 2022

Hey there @lindexi! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@rmarinho
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rmarinho rmarinho self-requested a review August 22, 2022 12:07
@rmarinho
Copy link
Member

@lindexi you need to fix the usage also. and public api file

@lindexi
Copy link
Member Author

lindexi commented Aug 22, 2022

@rmarinho Thank you

@lindexi lindexi force-pushed the t/lindexi/ScrollToRequest branch from 81325db to 866b72d Compare August 23, 2022 00:51
@rmarinho
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mattleibow
Copy link
Member

mattleibow commented Aug 25, 2022

@lindexi add this tp all the PublicAPI.Unshipped.txt files in the Core project:

*REMOVED*Microsoft.Maui.ScrollToRequest.HoriztonalOffset.get -> double
*REMOVED*Microsoft.Maui.ScrollToRequest.HoriztonalOffset.init -> void
*REMOVED*Microsoft.Maui.ScrollToRequest.ScrollToRequest(double HoriztonalOffset, double VerticalOffset, bool Instant) -> void
Microsoft.Maui.ScrollToRequest.HorizontalOffset.get -> double
Microsoft.Maui.ScrollToRequest.HorizontalOffset.init -> void
Microsoft.Maui.ScrollToRequest.ScrollToRequest(double HorizontalOffset, double VerticalOffset, bool Instant) -> void

@rmarinho
Copy link
Member

Fixed with #9661 9661

@rmarinho rmarinho closed this Aug 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community ✨ Community Contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants