Secondary ButtonMask

[PureWeen]

Description of Change

This adds ButtonMask to TapGestureRecognizer which allows users to indicate if they want secondary and/or primary to trigger the gesture.

• Secondary currently won't work with "NumberOfTapsRequired"
• Remove ClickGestureRecognizer. This wasn't hooked up to anything in .NET MAUI so we're not removing any behavior by deleting this recognizer. It seems a bit excessive and confusing to have a separate recognizer here. Once we get to a point where a user will need to determinate the type of device triggering a Tap we can just add an enum or similar.

Status

• Currently works only for WinUI. Feel free to review and merge this PR in it current state so the APIs can get in for NET 7.0

API Changes

Maui.Controls

namespace Microsoft.Maui.Controls
{
	public sealed class TapGestureRecognizer : GestureRecognizer
	{
		public static readonly BindableProperty ButtonsProperty = BindableProperty.Create(nameof(Buttons), typeof(ButtonsMask), typeof(TapGestureRecognizer), ButtonsMask.Primary);

namespace Microsoft.Maui.Controls
{	
        public class TappedEventArgs : EventArgs
	{
		// Allow users to request the location of the tap relative to any view 
		 public Point? GetPosition(Element? relativeTo);

		public ButtonsMask Buttons { get; private set; }

		// This was just EventHandler? Tapped.
		public event EventHandler<TappedEventArgs>? Tapped;

Issues Fixed

Fixes #9140

[PureWeen]

This was only wired up to GTK and macOS in XF. Currently in .NET MAUI this gesture does nothing anywhere. I think just condensing down into the TapGestureRecognizer here makes the most sense.

[PureWeen]

Most the changes in this file are organizational. There seemed to be a lot of duplicated code added to process spans. I needed that same code generalized so I could use it from a UIContextMenu.

The code here is the main code required to make right click fire an event on catalyst.

[PureWeen]

This is the other functional addition to the code. Most of the other changes in this file are organizational

[hartez]

Looks pretty good, a few small things.

[hartez]

Can getPosition default to null and reduce the noise of all the SendTapped(..., null) calls?

[PureWeen]

👍

Also @rookiejava FYI if you want to extend your usages of "SendTapped" to provide location data.

[PureWeen]

#9653

[dotMorten]

So @PureWeen was this meant to be a breaking change hosing any .NET 6 components?