Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tizen] Update handling IconPressed event of MauiToolbar #9769

Merged
merged 1 commit into from
Aug 31, 2022
Merged

[Tizen] Update handling IconPressed event of MauiToolbar #9769

merged 1 commit into from
Aug 31, 2022

Conversation

shyunMin
Copy link
Contributor

Description of Change

This PR is to improve the event handling when a user click the toggle/back button of the Toolbar on Tizen.

  • the event that triggers BackButtonPressed will be handled in MauiToolbarHandler.Tizen.
  • the event that opens the drawer will be handled in each handlers in charge of the drawer control.

Screenshot

  • FlyoutPage
  • Shell

@ghost ghost added the community ✨ Community Contribution label Aug 30, 2022
@ghost
Copy link

ghost commented Aug 30, 2022

Hey there @shyunMin! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jsuarezruiz jsuarezruiz added the platform/tizen Samsung Tizen Devices (TV) label Aug 30, 2022
@rmarinho
Copy link
Member

rmarinho commented Aug 30, 2022 •
edited
Loading

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rmarinho
Copy link
Member

@rookiejava looks good?

@rookiejava
Copy link
Contributor

@rookiejava looks good?
Yes,I already reviewed it internally. 😉

@mattleibow mattleibow merged commit 6441449 into dotnet:net6.0 Aug 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
@samhouts samhouts added fixed-in-6.0.540 Look for this fix in 6.0.540 SR5! fixed-in-7.0.0-rc.1.6683 labels Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

Assignees
No one assigned
Labels
community ✨ Community Contribution fixed-in-6.0.540 Look for this fix in 6.0.540 SR5! fixed-in-7.0.0-rc.1.6683 platform/tizen Samsung Tizen Devices (TV)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shyunMin @rmarinho @rookiejava @mattleibow @jsuarezruiz @samhouts